Page 1 of 1

Error with serendipity_ReplyTo

Posted: Fri Mar 23, 2007 12:31 am
by zz1
Hello, I'm new to this forum, but would genuinely appeciate some help with the following...

1. I add a comment to a blog entry.

2. Serendipity comes back and says that is successfully added the comment.

3. But if I click on the "(Reply)" link next to any of the comments that are shown on the page, nothing happens (except that I can see a page error being report by my browser). i.e. !Error shown in the bottom left corner of Internet Explorer. If I open up the error, it says "'document.getElementById(...)' is null or not an object".

I tried doing a "view source" in the browser and can see that what was in the parenthesis was "serendipity_replyTo". I did some more checking with "view source" and can see that nothing with id="serendipity_replyTo" is in the code that was sent to my browser.

However, I checked, and before I added the comment, the "(Reply)" did work, and I could see with view source that there was something on the page with id="serendipity_replyTo".

Thanks in advance for any help you can provide.

Re: Error with serendipity_ReplyTo

Posted: Fri Mar 23, 2007 10:24 am
by garvinhicking
Hi!

The actual problem with this is that the "Reply To" functionality requires that a contact form is present on the page.

However if you just recently commented, the comment form is no longer there (to prevent spam from bad users that will post again and again).

Sadly the problem you describe became apparent a bit too late - it would need to be fixed in the comment.tpl file which would need to reload the whole page when clicking on "reply to" so that you have a valid form again. But we now have so many templates with customized comment.tpl, that we cannot fix this simply for all of them, but would need to do that singularly for every theme.

I tried doing a "view source" in the browser and can see that what was in the parenthesis was "serendipity_replyTo". I did some more checking with "view source" and can see that nothing with id="serendipity_replyTo" is in the code that was sent to my browser.

So if you before clicking on reply first go to the article page again so that you have a commentform again, it would work as intended.

A proper fix for this would be to edit the comments.tpl file of a template and either remove the replyto link when a comment has just been sent, and/or change the javascript-call to actually check if a comment form is there and if not, reload the page....

Best regards,
Garvin