Page 1 of 1
patch to make carl_contest css and xhtml validate
Posted: Wed Jan 10, 2007 1:50 am
by jkv
Problem:
- Use of comments inside comments(not xml valid)
- a </div> was in surplus
Update:
Finally got it sorted, if anyone uses this template please test the patch and reply if it break something...
unified diff:
http://www.unixcluster.dk/stuff/patches ... test.patch
Posted: Thu Jan 11, 2007 10:42 pm
by carl_galloway
Hi jkv, I got your email, just been too busy to reply, and then saw this thread so forgive me for replying here.
Thanks for the heads up, I'll take a look at your suggestions over the next few days and email Garvin once I've been able to check them against my test server.
Posted: Thu Jan 11, 2007 11:13 pm
by jkv
carl_galloway wrote:Hi jkv, I got your email, just been too busy to reply, and then saw this thread so forgive me for replying here.
Thanks for the heads up, I'll take a look at your suggestions over the next few days and email Garvin once I've been able to check them against my test server.
No problem...
Got the last problem sorted out, another </div> was misplaced, need to be placed before line 175 in entries.tpl, updated the patch to reflect this...
Speaking of debugging, do you have any 'need to know' hints on this subject?
At the moment im using a perl s///g to insert debug statements into the template im debugging. I want to know when a control statement starts and ends...
I wrote a onliner to help me debug, but it would really help with a GUI editor which can expand/shrink control statements...
perl -ple 's/{\/if}/<!-- \/if $. --> {\/if}/g ; s/({if.+?})/\1<!-- if $. -->/g ; s/({foreach.+})/\1<!-- foreach $. -->/g ; s/{\/foreach}/<!-- \/foreach $. -->{\/foreach}/g' < entries.tpl.orig > entries.tpl