Serendipity Forums

Hello, the Gravatar Event Plugin 1.14 has the problem that pickAvatar has a $cache parameter and a $cache static. The later is used for favatars and should be named $cache_dir.

The effect of this is, that gravatars are never cached.

Also: the $cache value should be used for favatars instead of the hardcoded value.

Also: right now gravatar.com is returning images for unknown users with no HTTP error code. I am not sure if that is a temporary problem or intentional. I mailed gravatar owner but did not get feedback.

It is possible to recognize those icons by size and ETag.

Bernd

BTW: the not cache bug is critical - privacy issue.

Hi!

Thanks for reporting! I'll take care of fixing this next week when I return from a short trip

Regards,
Garvin

eckes, I just commited this to CVS. It looks good to me, but I'd like you to give it a test anyway; I'm worried that the $cache variable will prevent fallback from working properly.

judebert wrote:eckes, I just commited this to CVS. It looks good to me, but I'd like you to give it a test anyway; I'm worried that the $cache variable will prevent fallback from working properly.

Ok, the diff looks good to me, however I wonder:

$cache_dir = $serendipity['serendipityPath'] . PATH_SMARTY_COMPILE . '/favatar';

$cache_dir = $serendipity['serendipityPath'] . $serendipity['uploadPath'] . '/gravatar';

Maybe the favatar directory should also be located in the uploadPath?

I am not using the fallback, so i cant really comment on this.

Gruss
Bernd

Not knowing the difference, I don't think I'm willing to mess with it.