Page 1 of 1

New Freshy theme port

Posted: Wed Dec 13, 2006 11:03 am
by abdussamad
Hi

As requested by another s9y user I have ported the very popular freshy theme to serendipity. I've tested it in s9y 0.9-1.1 and it works fine. However in case anybody finds any major bugs please post here. This is a partial port that includes most of the features of the original wordpress version including some admin control panel options. I hope you guys like it.

Best Regards,

Re: New Freshy theme port

Posted: Wed Dec 13, 2006 12:24 pm
by yellowled
abdussamad wrote:However in case anybody finds any major bugs please post here.
No major bugs (so far, hrhr :wink:), but 2 little things (FF 1.5/Linux): I think it's a pity the sidebar (only tested it with single sidebar) doesn't expand to the bottom (you might want to add sliding faux columns or something similar to achieve that), and - I don't know whether this is unwanted or not - the background image for the navbar/menu is displayed once at the very right end of the menu.

I also suggest that you take a look at http://www.s9y.org/forums/viewtopic.php?t=7513 and maybe use Garvins great code for the navbar/menu. I also think it could be a little irritating for users that the navbar links in the template options start with #2.

Other than that, great job :)

YL

Posted: Wed Dec 13, 2006 2:40 pm
by abdussamad
No major bugs (so far, hrhr Wink), but 2 little things (FF 1.5/Linux): I think it's a pity the sidebar (only tested it with single sidebar) doesn't expand to the bottom (you might want to add sliding faux columns or something similar to achieve that), and - I don't know whether this is unwanted or not - the background image for the navbar/menu is displayed once at the very right end of the menu.

I also suggest that you take a look at http://www.s9y.org/forums/viewtopic.php?t=7513 and maybe use Garvins great code for the navbar/menu. I also think it could be a little irritating for users that the navbar links in the template options start with #2.

Other than that, great job Smile
Keep in mind that the css code is by the original author Julien. So unless there is a major bug I probably won't be messing with it. Minor differences in rendering between browsers are almost certain to occur with this theme. If there is a major problem like bad contrast between text and background or something like that then I'll look into it.

Re. the nav bar links they begin with #2 because the first link pointing to the home page is included automatically. Also links are only included if they are not pointing to the default "#". So if you retain that then a link will not be included at all.

Posted: Wed Dec 13, 2006 5:46 pm
by carl_galloway
Nice! It looks like you have taken great efforts to remain faithful to the original design. Well done.

I do have one possible critique if I may, the background image for the code samples possible needs to be brought down by a few pixels. On my browsers it sits too high in relation to the actual text.

Posted: Wed Dec 13, 2006 5:53 pm
by yellowled
abdussamad wrote:Keep in mind that the css code is by the original author Julien.
Point well taken.
abdussamad wrote:Re. the nav bar links they begin with #2 because the first link pointing to the home page is included automatically.
Another suggestion: Put the last template option (highlight for the menu) in front of the navbar links. I almost overlooked it because there are so many navbar link possibilies (that's why I suggested using Garvin's code).

YL

Posted: Thu Dec 14, 2006 6:34 am
by abdussamad
carl_galloway wrote:Nice! It looks like you have taken great efforts to remain faithful to the original design. Well done.

I do have one possible critique if I may, the background image for the code samples possible needs to be brought down by a few pixels. On my browsers it sits too high in relation to the actual text.
:D honestly I didn't even know that the theme included special styling for <code> blocks. Looks very nice to me.