hemingway and error contactform

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

hemingway and error contactform

Post by Timbalu »

Hi Carl

When you get an error from contactform, it will show startpage hemmingway on top of the backsended contactform, while this links to index.php#feedback.

Is this a problem of contactform plugin, or is there a possibility to code a check in the hemingway theme?

Regards,
Ian
carl_galloway
Regular
Posts: 1331
Joined: Sun Dec 04, 2005 5:43 pm
Location: Andalucia, Spain
Contact:

Post by carl_galloway »

ouch, I'll have to take a look at that, the problem is that Hemingway is so different from other templates that I had to code it using the $view variables, and something is obviously not working like it should. This is an issue that I think is likely to come up more and more as templates designers start breaking with tradition. I promise to get this fixed, but I have to replicate the fault first then identify where in the logic the error is coming from. I'm really sorry to say I don't know how long this will take me, so if Garvin or one of the developers would like to take a shot at working out the problem that would be awesome.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Post by Timbalu »

Hi Carl

I managed to get it working changing index.tpl $view == entry like this:

Code: Select all

{if $view == "entry" or $staticpage_pagetitle}
<div id="primary" class="single-post">
	<div class="inside"><!-- entries_single.tpl -->
		{if $is_contactform_error == true}{ include file="plugin_contactform.tpl"}{else}
		{ include file="entries_single.tpl"}{/if}
	</div>
	<div class="clear"></div>
</div>
{elseif $view == "start" }
Afterwords I had some problems with the css directives, but found a solution for this too.

Regards,
Ian
carl_galloway
Regular
Posts: 1331
Joined: Sun Dec 04, 2005 5:43 pm
Location: Andalucia, Spain
Contact:

Post by carl_galloway »

Thanks Ian, I really appreciate your patience and perseverence. Your fix looks good and I'll go ahead an integrate it into my version over the next couple of days.

As a matter of interest, what were the css fixes?

I haven't one any work on Hemingway since Garvin went on holiday, its still only a test template, and a couple of people have emailed me with other minor annoyances which I plan to fix before finally releasing it. Also, I need to touch base with Garvin about the sidebar selector and see if he's finalised the code for this.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Post by Timbalu »

well these fixes are just quick hacks, nothing really good to integrate into something public.
And I still got problems with IE.

Ian
Post Reply