All categories URL should use "?frontpage"

mverdier · Post by **mverdier** » Fri Aug 25, 2006 8:25 pm

When using static pages the frontpage is not the all categories page. This page is accessible with <index url>?frontpage

diff include/plugin_internal.inc.php.orig include/plugin_internal.inc.php
1514c1514
< $serendipity['serendipityHTTPPath'] . $serendipity['indexFile'],
---
> $serendipity['serendipityHTTPPath'] . $serendipity['indexFile'] . '?frontpage',

diff templates/default/plugin_categories.tpl.orig templates/default/plugin_categories.tpl
26c26
< <div class="category_link_all"><a href="{$form_url}" title="{$CONST.ALL_CATEGORIES}">{$CONST.ALL_CATEGORIES}</a></div>
---
> <div class="category_link_all"><br /><a href="{$form_url}?frontpage" title="{$CONST.ALL_CATEGORIES}">{$CONST.ALL_CATEGORIES}</a></div>

judebert · Post by **judebert** » Mon Aug 28, 2006 10:15 pm

Bump.

Garvin, is this really the case? If so, won't we have to change the .htaccess as well?

Post by **garvinhicking** » Mon Aug 28, 2006 10:51 pm

Hi!

We can'T divert all links to ?frontpage. The reason why '?frontpage' is required is to get to the s9y frontpage; but a "frontpage" once a staticpage startpage is defined is no longer the s9y frontpage.

For the categories plugin this is a seperate case, so there I agree it could need fixing.

Best regards,
Garvin

mverdier · Post by **mverdier** » Mon Aug 28, 2006 11:21 pm

I post a diff for the "all categories" url. This is always the "?frontpage" with or without static page. When a static page is made the front page, it is "/" or "index.php" which points to this static page. Then "all categories" whithout the patch is invalid because it points to the static page. I have patch this diff on my own site precisely to use a static page as front page.

Post by **garvinhicking** » Mon Aug 28, 2006 11:32 pm

Hi!

Thanks mverdier for clarifying - this was actually what I was trying to say. Yes, your patch makes sense!

Judebert, would you like to commit that?

Best regards,
Garvin

judebert · Post by **judebert** » Tue Aug 29, 2006 1:39 pm

I just commited this to the 1.1 baseline! Thanks for the patch!

Incidentally, it looks like you're using 1.0; I had to search a bit for the plugin_internal.inc.php line. But your clarification made it all make sense!

mverdier · Post by **mverdier** » Tue Aug 29, 2006 4:45 pm

judebert wrote:I just commited this to the 1.1 baseline! Thanks for the patch!

Incidentally, it looks like you're using 1.0;

Thanks for applying it !
Yes I'm using 1.0 in production. And I'm too lazy to install a test 1.1...

carl_galloway · Post by **carl_galloway** » Sat Sep 02, 2006 10:34 pm

May I ask a followup question?

In templates, if a separate startpage is required we use the {$startpage} or $view =="start" variables. This is fine, but the categories list (sidebar plugin) links to the same location when 'All Categories' link is followed.

Is there any possibility of changing the 'all categories' link in the sidebar categories list to point instead to archives/P1.html, which is really where logic says it should point to? This change would allow the start page and archives/P1.html page to be different, and gives a lot more scope for feature rich templates that could mimic high-end CMS's

mverdier · Post by **mverdier** » Sun Sep 03, 2006 10:37 am

I forgot the P1.html page. For me it is ok to use it.
But it is more complex. Without rewriting it should be index.php?/archives/P1.html.