BBCode opens new windows for URLs

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

BBCode opens new windows for URLs

Post by Shoup »

Does BBCode by default open a new window for links?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: BBCode opens new windows for URLs

Post by garvinhicking »

No.

Opening a new window for links is a matter of the browser. Websites should not overrule the visitors preference.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

Post by Shoup »

I'm not sure if it is a browser setting, though. I inserted links using html and BBCode, and the html ones stay in the parent window, but the BBCode ones open new windows.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Oh my god. You are right. I'm terribly sorry for sounding so rude, and also being wrong with my statement. :-(

The bbcode plugin does in fact add a 'target=_blank' attribute. I just patched the plugin so that this behaviour is now configurable. Please get the latest version of that plugin file here:

http://svn.berlios.de/viewcvs/serendipi ... nt_bbcode/

HTH,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

Post by Shoup »

garvinhicking wrote:Hi!

Oh my god. You are right. I'm terribly sorry for sounding so rude, and also being wrong with my statement. :-(

HTH,
Garvin
No worries. Thanks for all of your help. :)
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

Post by Shoup »

I'm so accustomed to Spartacus, I'm not sure how to update a plugin by hand. I uploaded the serendipity_event_bbcode.php and the lang_en.inc.php files to the serendipity_event_bbcode, but I'm not sure what to do next to get the system to recognize them and give me the radio or checkbox to change the option for the target.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Usually if you overwrite the existing files with the ones you downloaded from the CVS link I gave you, it should already be recognized by the system!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Make sure you overwrite all the files from the plugin. More may have changed than just the .php file.

Incidentally, I'm please to meet another person dedicated to preserving the use of "accustomed" in the English language. 8)
Judebert
---
Website | Wishlist | PayPal
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

Post by Shoup »

So I need to update all of the foreign language files? They all had modification dates much older than the two files I updated.

Also, is it possible to download the entire plugin at once instead of file by file on the berliOS site?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

If you have a CVS/SVN clientl, you could do that.

Else, the spartaucs site usually bundles that. But since my server is down, it doesn't. I hope it will be functioning again at the end of next week.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Shoup
Regular
Posts: 26
Joined: Mon Jul 10, 2006 9:25 pm

Post by Shoup »

I think I figured out the download thing. But I updated all of the files and it still isn't showing the option for target.

Maybe because I'm still on version 1.0? We're waiting to upgrade to 1.1 until it's the recommended release.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

There sadly was a spelling error in that file. Since currently I am developing "blind" without my dev-server, I didn'T notice that. At the SVN location you should find the updated file.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply