Page 1 of 1

[at] in email should be %5Bat%5D

Posted: Sun Aug 20, 2006 5:44 pm
by mverdier
diff functions_comments.inc.php.orig functions_comments.inc.php
260c260
< $comment['email'] = htmlspecialchars(str_replace('@', '[at]', $comment['email']));
---
> $comment['email'] = htmlspecialchars(str_replace('@', '%5Bat%5D', $comment['email']));

[] are forbidden in w3c recommandations

Re: [at] in email should be %5Bat%5D

Posted: Mon Aug 21, 2006 12:42 pm
by garvinhicking
Hi!

Sadly this is not the only place where [] would need to be changed; we have it on a lot of other occasions as well. Which is sad. But also sadly many other applications contain that flaw.

The only good thing about this is, that virtually every server and browser I've seen in the past has no problem interpreting [] ;)

Many thanks for your help and feedback!

Best regards,
Garvin

Posted: Mon Aug 21, 2006 4:39 pm
by mverdier
In fact I used s9y without problem. But I've recently tried to validate my site with ht//check which see all [] as badly formatted url. Of course there is some more [] (cview, etc) in s9y but this one is easy to correct.