[at] in email should be %5Bat%5D

Found a bug? Tell us!!
Post Reply
mverdier
Regular
Posts: 8
Joined: Sun Aug 20, 2006 5:36 pm
Location: Paris, France

[at] in email should be %5Bat%5D

Post by mverdier »

diff functions_comments.inc.php.orig functions_comments.inc.php
260c260
< $comment['email'] = htmlspecialchars(str_replace('@', '[at]', $comment['email']));
---
> $comment['email'] = htmlspecialchars(str_replace('@', '%5Bat%5D', $comment['email']));

[] are forbidden in w3c recommandations
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [at] in email should be %5Bat%5D

Post by garvinhicking »

Hi!

Sadly this is not the only place where [] would need to be changed; we have it on a lot of other occasions as well. Which is sad. But also sadly many other applications contain that flaw.

The only good thing about this is, that virtually every server and browser I've seen in the past has no problem interpreting [] ;)

Many thanks for your help and feedback!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mverdier
Regular
Posts: 8
Joined: Sun Aug 20, 2006 5:36 pm
Location: Paris, France

Post by mverdier »

In fact I used s9y without problem. But I've recently tried to validate my site with ht//check which see all [] as badly formatted url. Of course there is some more [] (cview, etc) in s9y but this one is easy to correct.
Post Reply