Bug(?) in serendipity_admin_image_selector.php
Posted: Sun Aug 06, 2006 11:09 am
An s9y blog with open_basedir restriction in effect, when selecting to add an image to an entry, PHP complains that file_exists() in serendipity_admin_image_selector.php/line 136 is violating the open_basedir restriction on "/uploads/picture.jpg".
$file['imgsrc'] is the URL path, and not the filesystem path, therefor causing the open_basedir restriction condition. However, when reading the comments in the else-part of this construct (around line 220), it seems that checking whether the file does not exist is not even intended:
Thus, the change on lince 136 should be either:
or something like (untested):
I changed it to the first version, which I believe to be the actually intended logic, and it works fine.
Code: Select all
if (!file_exists($file['imgsrc']) && $is_image) {Code: Select all
} else {
// What to do if file is no image.
// For the future, maybe allow the user to add title/link description and target windowCode: Select all
if ($is_image) {Code: Select all
if (!file_exists($serendipity['serendipityPath'] . $file['imgsrc']) && $is_image) {