Page 1 of 2

Tags plugin question

Posted: Thu Jun 29, 2006 5:02 pm
by hgoor
Hi,

I'm using the tags plugin and I was wondering if I am missing something.

When I open an antry I see all the tags that I made so far under the story. They are all underlined like they are clickable and as such can be added to as tags to the stories without having to type them in.

However, when I click a tag, nothing happens?

I tried it both in IE and Firefox (the latter being my default browser).

Am I supposed to add tags to stories by clicking on them? Or is this not the idea behind them being presented as links?

With del.ico.us for instance you do not have to endlessly repeat typing in tags, but they are showed in a nice (ajax?) way and you just select whatever you already had.

(I suggest btw that it is possible to have a more elaborate read.me or or whatever, for spartacus so you can have a more indepth idea what a certain plugin does and what/if there are any dependencies that are unmet.)

Re: Tags plugin question

Posted: Thu Jun 29, 2006 5:08 pm
by garvinhicking
Hi!

You might need to upgrade to the latest freetag plugin; just recently I needed to commit a change to properly insert clicked tags into the textarea. You also might want to check your JS Error console in the browser...

Best regards,
Garvin

Re: Tags plugin question

Posted: Thu Jun 29, 2006 10:22 pm
by hgoor
Ok, not to mention that I get loads of JS errors/warnings in Serendipity (what a mess), this is what it says when I click a tag:
Error: tags[tag].toLowerCase is not a function
Source File: http://zion.demon.nl/serendipity/serendipity_admin.php?
serendipity[action]=admin&serendipity[adminModule]=entries&serendipity[adminAction]=edit&serendipity[id]=377
Line: 711
I guess I need to upgrade to version 2.52 [strike](I have 2.31) but csv.sourceforge seems down... I'll try another mirror..

Posted: Thu Jun 29, 2006 10:36 pm
by hgoor
Ok I just upgraded to version 2.52 and it still doesn't work:
Error: str.replace is not a function
Source File: http://zion.demon.nl/serendipity/serend ... erendipity
[action]=admin&serendipity[adminModule]=entries&serendipity[adminAction]=edit&serendipity[id]=377
Line: 721
I really do not like the idea to have to type all the tags each time!

Posted: Fri Jun 30, 2006 8:26 am
by garvinhicking
Hi!

Okay, I got it fixed now! I only checked the insertion of new tags when no tag yet existed, but not for existing entries. It now works in both in version 2.53.

Best regards,
Garvin

Posted: Fri Jun 30, 2006 11:52 am
by hgoor
garvinhicking wrote:Hi!

Okay, I got it fixed now! I only checked the insertion of new tags when no tag yet existed, but not for existing entries. It now works in both in version 2.53.

Best regards,
Garvin
So what do I do? Just wait till Spartacus tells me there is an upgrade?

(btw: Kudos for the quick response)

Posted: Fri Jun 30, 2006 11:59 am
by garvinhicking
Hi!

Yes, either you wait for that, or you manually get it from here:

http://php-blog.cvs.sourceforge.net/php ... 63&r2=1.64

or

http://php-blog.cvs.sourceforge.net/*ch ... ision=1.64

HTH,
Garvin

Posted: Fri Jun 30, 2006 12:15 pm
by hgoor
Hehe, couldn't wait, so I just downloaded & installed it, will let you know if this works :-)

Posted: Fri Jun 30, 2006 12:22 pm
by hgoor
hgoor wrote:Hehe, couldn't wait, so I just downloaded & installed it, will let you know if this works :-)
Pff, it does not work....
Error: tag[tag].toLowerCase is not a function
I think I'll give up this thing and just stop the tagging stuff. I liked the idea but if I have to type in all the tags it's jus no use.. Sorry to say...

Btw: turning lowercase off in the settings doesn't influence anything either: keep getting the same error...

Posted: Fri Jun 30, 2006 12:40 pm
by garvinhicking
Hi!

Please don't give up your patience. It really does work, it's not that hard - and it's meant to work exactly like you want it. In fact it works for new entries, as you might already have seen. :)

Are you sure the error is like this:
Error: tag[tag].toLowerCase is not a function
Because nowhere in the code I could find "tag[tag]". It should read "tags[tag]"!

Did you download the PHP file and overwrite the old one?

Best regards,
Garvin

Posted: Fri Jun 30, 2006 1:14 pm
by hgoor
Yeah sorry: it's tagS with a "S": it was a typo on my part.

Previous times I was able to cut & paste the error from the JS console, but I'm currently on my Mac and for some dumb reason Firefox on Mac doesn't allow cut & past so I had to type it over... My bad...

Posted: Fri Jun 30, 2006 1:33 pm
by garvinhicking
Hi!

Hhm...but it works here on my Firefox 1.5.0.4 -- which version are you running? "toLowerCase" should exist though.

How does your input field look like where you try to add a tag, and what is the tag name that you click on?

Regards,
GArvin

Posted: Fri Jun 30, 2006 1:50 pm
by hgoor
garvinhicking wrote:Hhm...but it works here on my Firefox 1.5.0.4 -- which version are you running? "toLowerCase" should exist though.

How does your input field look like where you try to add a tag, and what is the tag name that you click on?

Regards,
GArvin
Same version, Mac OS X. I click randomly on some tags to make sure I have a response in the JS console. Just double-checked the version ot the plugin and it says 2.53.

Error is still the same.... I will start & stop my webserver and database and also Firefox and let you know what goes...

UPDATE: nope, no go. I started/stopped all services and killed Firefox and emptied cache, still the same error:
Error: tags[tag].toLowerCase is not a function
Line: 711

Posted: Fri Jun 30, 2006 1:58 pm
by garvinhicking
Hi!

Could you tell me please exactly "How does your input field look like where you try to add a tag, and what is the tag name that you click on?"

I need this to try it on my installation because it works here as expected. :-O

Best regards,
Garvin

Posted: Fri Jun 30, 2006 2:24 pm
by hgoor
garvinhicking wrote:Hi!

Could you tell me please exactly "How does your input field look like where you try to add a tag, and what is the tag name that you click on?"

I need this to try it on my installation because it works here as expected. :-O

Best regards,
Garvin
Well, like this:

http://zion.demon.nl/gfx/screenshot.jpg

http://zion.demon.nl/gfx/screenshot1.jpg

The first one is an exsiting article, second a new article.

I virtually clicked on ALL tags... Nothing happens...