Page 1 of 1

improvement: bundled-libs/HTTP/Request.php

Posted: Wed May 24, 2006 6:55 pm
by twobee
and again in line 18 :)

find

Code: Select all

        $separator = ini_get('arg_separator.output');
        ini_set('arg_separator.output', '&');
        $querystring = ($querystring = $this->_url->getQueryString()) ? '?' . $querystring : '';
        ini_set('arg_separator.output', $separator);
and replace with

Code: Select all

if (function_exists('ini_set')
    {
        $separator = ini_get('arg_separator.output');
        ini_set('arg_separator.output', '&');
        $querystring = ($querystring = $this->_url->getQueryString()) ? '?' . $querystring : '';
        ini_set('arg_separator.output', $separator);
    }
it also works without the replacement, or better it worked on my server. The change is only to inhibit any error messages.


p.s.: Yes, I do have a very restrictive php.ini ;)

regards,

twobee

Re: improvement: bundled-libs/HTTP/Request.php

Posted: Fri May 26, 2006 1:51 pm
by garvinhicking
Hi!

We try to not creat forked/branched versions of foreign APis like PEAR HTTP:Request. So please try to get your patch committed to the official PEAR package, and then we can upgrade to the latest one. :)

Best regards,
Garvin