split long entries: entry body on succeeding pages

Found a bug? Tell us!!
bconnolly

split long entries: entry body on succeeding pages

Post by bconnolly »

using 1.0 alpha2
split long entries 1.4

trying to use split long entries... but when "entry body on succeeding pages" is set to "no"... it still does.

Thoughts?
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: split long entries: entry body on succeeding pages

Post by garvinhicking »

The body is only "killed" when you are on page 2 or larger of the entry.

Do you have an example URL where this behaviour can be seen?

What are your exact settings of the plugin?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
bconnolly

Post by bconnolly »

I cannot display an example of it presently. My site is live and the article in particular is being visited.

Let me try to re-explain: The only two setting (really) for split long entries, are length and whether (yes/no) to show "entry body on succeeding pages."
I have the length set to 2000 and the "entry body on suceeding pages" set to "no." What happens then is that pn all pages, the entry boy is redisplayed.

See?

BC
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

It works for me perfectly fine. If your site is live, all the better for us to see!

You know that the entrysplitting only affects the EXTENDED body, right? And the radio toggle you set only affects the DEFAULT BODY, that will not get displayed on succeeding pages...

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Guest

Post by Guest »

Sorry. Again, the site is live and the particular article in swimming around the Corante Marketing Hub. I just rather not confuse visitors by using it as a test site.

But that said, here let me demonstrate.

page 1: entry body
page 2: entry body + some extended text
Page 3: entry body + more extended text

For it to be useable, pages 2 and 3 should not include the entry body.

That's all.

Brian

PS The behavior is happening on my home WAMP box, as well.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

I don't understand your "live site" argument. I'm not saying that we need to change anything, I just want to SEE it. :-)
For it to be useable, pages 2 and 3 should not include the entry body.
Yes, that works perfectly fine here on my setup (1.0-alpha2 plus 1.4 of the plugin). My guess is that some other event plugins might be interfering. Try to put the splitentry plugin below the entryproperties plugin.

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Guest

Post by Guest »

see http://viewsfromthetower.com .

But I am only going to leave it up for 15 minutes, or so.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Okay, now I see it. Tell me if my event plugin tip helped, and if not, which event plugins you also have installed.

Inside the serendipity_event_entrysplit.php file there's this code:

Code: Select all

                    if ($current_page > 1 && !serendipity_db_bool($this->get_config('showbody'))) {
                        $bodytext = &$this->getFieldReference('body', $eventData);
                        $bodytext = '';
                    }
This is the one that resets your body text. You could change it to this:

Code: Select all

if ($current_page > 1 && !serendipity_db_bool($this->get_config('showbody'))) {
    die('YES, Stripping takes place. But it does not really work');
} else {
    die('NO Stripping. Page is ' . $current_page . '.');
}
This will make the plugin die with a code that might lead up to the problem.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Guest

Post by Guest »

With code replacement as you suggested:

Full article link results in blank page with only the following on top: "NO Stripping. Page is 1."

With regard to the other installed plugins, these include:

serendipity_event_browsercompatibility
serendipity_event_categorytemplates
serendipity_event_contactform
serendipity_event_entrycheck
serendipity_event_entrylastmodified
serendipity_event_entrypaging
serendipity_event_entryproperties
serendipity_event_imageselectorplus
serendipity_event_kubrickheader
serendipity_event_linklist
serendipity_event_livecomment
serendipity_event_mailer
serendipity_event_metainformation_standard
serendipity_event_mycalendar
serendipity_event_podcast
serendipity_event_popfetcher
serendipity_event_randomblogdescription
serendipity_event_s9ymarkup
serendipity_event_sidebarhider
serendipity_event_spamblock
serendipity_event_spamblock_rbl
serendipity_event_spamblock_surbl
serendipity_event_spartacus
serendipity_event_staticpage
serendipity_event_statistics
serendipity_event_trackback
serendipity_event_usergallery
serendipity_event_weblogping
serendipity_event_xhtmlcleanup
serendipity_plugin_eventwrapper
serendipity_plugin_remoterss

All are current.
bconnolly

Post by bconnolly »

UPDATE: I've uninstalled serendipity_event_entryproperties on my local WAMP box and it now seems to work.

I am going to try that on the live site.

Standby.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Full article link results in blank page with only the following on top: "NO Stripping. Page is 1."
If you get that output it means, that "showbody" is not set to "disabled" in your plugin config!
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
bconnolly

Post by bconnolly »

But it is set to disabled.

I think the culprit is entryproperties. With that uninstalled, it all works.

Well, almost. It works perfect in IE. In FF and Opera... the line break between the first and second paragraph on subsequent pages (2, 3, etc.) is lost.

Thoughts?

Brian

PS you can see it live on http://viewsfromthetower.com .
bconnolly

Post by bconnolly »

Also noted:

Technically speaking, all pages should be of equal length except the last page (of course). That is, if it is set to 2500 characters, all pages should be 2500 characters (except the last).

Currently, page one is 2500 characters plus the length of the entry body.
bconnolly

Post by bconnolly »

NOTE: I've disable split long entries for now.
bconnolly

Post by bconnolly »

Garvin:

At your convenience, can we revist this. As last we spoke, there were 3 issues with this plugin:

1. incompatable with entryproperties ;
2. consistent page length (page 1 doesn't = page 2);
3. losing paragraph breaks <p> between pages.

Thoughts?

Brian
Post Reply