Page 1 of 1
serendipity_event_xinha bug ?
Posted: Mon Nov 07, 2005 11:37 pm
by Alex22
Hi,
i noticed may be a bug in serendipity_event_xinha on line 221
Code: Select all
$IMConfig['images_url'] = $serendipity['serendipityHTTPPath'] . '/uploads/';
doesn't seem to return right serendipity http path to 'insert image' xinha plugin because thumbnails don't appear in image select popup and image path is bad [
http://uploads/image.thumbnail.jpg]
if i replace live 221 by :
Code: Select all
$IMConfig['images_url'] = 'http://www.mysite.com/uploads/';
then it works
is it a bug ?
thanks for help
Alex
Re: serendipity_event_xinha bug ?
Posted: Tue Nov 08, 2005 11:29 am
by garvinhicking
This sounds more like you misconfigure the serendipity paths in your serendipity admin. The "relative path to serendipity" may not ever have a "http://" string in it, and it always need to begin with a "/"!
Please check (or post) your path config, basically you don't need to change that URL setting.
Regards,
Garvin
Re: serendipity_event_xinha bug ?
Posted: Tue Nov 08, 2005 12:20 pm
by Alex22
garvinhicking wrote:This sounds more like you misconfigure the serendipity paths in your serendipity admin. The "relative path to serendipity" may not ever have a "http://" string in it, and it always need to begin with a "/"!
Please check (or post) your path config, basically you don't need to change that URL setting.
Regards,
Garvin
Hi
my relative path to serendipity is '/' automatically set when install.
Thanks for help
Alex
Re: serendipity_event_xinha bug ?
Posted: Tue Nov 08, 2005 12:34 pm
by garvinhicking
Hhhm...okay, so the images_url key needs to be an absolute URL, not a relative path you're saying? If that is the case, we can patch the plugin to use
$serendipity['baseURL'] instead of $serendipity['serendipityHTTPPath'] and should fix this with that?
Regards,
Garvin
Re: serendipity_event_xinha bug ?
Posted: Tue Nov 08, 2005 1:07 pm
by Guest
garvinhicking wrote:Hhhm...okay, so the images_url key needs to be an absolute URL, not a relative path you're saying? If that is the case, we can patch the plugin to use
$serendipity['baseURL'] instead of $serendipity['serendipityHTTPPath'] and should fix this with that?
Regards,
Garvin
Yes!
but right syntax is
Code: Select all
$IMConfig['images_url'] = $serendipity['baseURL'] . 'uploads/';
not
Code: Select all
$IMConfig['images_url'] = $serendipity['baseURL'] . '/uploads/';
because $serendipity['baseURL'] already end with /
thanks a lot for help Garvin
Alex
Re: serendipity_event_xinha bug ?
Posted: Tue Nov 08, 2005 1:12 pm
by garvinhicking
Thanks a lot, I've just committed this fix!
Regards,
Garvin
Posted: Tue Nov 22, 2005 12:04 am
by MySchizoBuddy
btw all images need to be absolute once the post is published.
u cannot have relative urls in it right.
