Page 1 of 1

Possible bug in extended options for image selection

Posted: Tue Nov 01, 2005 12:04 am
by Thomas
Hi,

I found the very new plugin in my brandnew 0.9 s9y. The plugin is very useful, specially then, when you serve a lot of images.
Actually there might be a bug in it. The plugin adds four options for how to display the target image:
- none
- popup (via Javascript)
- its own entry
- popup (via target=_blank)

I tried option number 3, its own entry. Well, first of all, the image is displayed raw, no article formatting done (maybe a possible enhancement). But aside the image an additional "<a href=" is displayed.

You can take a look at http://www.benqo.net/archives/195-Guck, ... aellt.html for a test. I modified an existing old entry for testing the new feature. Just click on the image to get the bigger version of.

Regards, Thomas

Posted: Tue Nov 01, 2005 12:06 am
by Thomas
Additional info: tried out the javascript option ... best idea ever to include that! :)

Posted: Thu Nov 03, 2005 10:53 am
by garvinhicking
Hi Thomas1

Thanks for reporting this, I just fixed the issue about the double link.

Regards,
Garvin

Posted: Fri Nov 04, 2005 9:58 pm
by Thomas
Am I right that I should see a red icon when a new version of a plugin is available? If yes, it's not the case in my installation. Actually I've seen that only once since I use 0.9 and that was immediatly after upgrading 0.8.5.

Posted: Sun Nov 06, 2005 12:23 am
by Thomas
Btw, another issue is that the target isn't set into " when using this option. I think this is not HTML compliant. Just 2 let u know. :)

Posted: Sun Nov 06, 2005 2:08 pm
by garvinhicking
(I'm on your spartacus problem, but this might take some more time)

What do you mean with the target thing, I don't understand it?

Regards,
Garvin

Posted: Sun Nov 06, 2005 10:29 pm
by garvinhicking
I've justed committed a fix which should get rid of teh spartacus upgrade problems; it'll be contained in tomorrows nightlies. It'll also be part of 0.9.1 which will be released because of this.

Regards,
Garvin

Posted: Mon Nov 07, 2005 9:32 pm
by Thomas
I meant with target following code:

Code: Select all

Right: target="_blank"
Wrong: target=_blank
The plugin uses line nr. 2. That's what I meant. ;)

Posted: Tue Nov 08, 2005 10:22 am
by garvinhicking
Ah, great. Just fixed! :)

Regards,
Garvin