Page 1 of 1

[partly fixed] serendipity_event_entrypaging plugin

Posted: Tue Oct 25, 2005 8:18 pm
by JWalker
Several bugs here:

1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.

2) Random entry does not appear. It depends on config bool variable 'showrandom' that is fetched from the database (line 164 of serendipity_event_entrypaging.php), but I did not see where it is user-accessible -- even in other parts of s9y.

3) The constant PLUGIN_ENTRYPAGING_BOTTOM is misspelled: PLUGIN_PENTRYPAGING_BOTTOM. This is in lang_de.inc.php and at line 47 of serendipity_event_entrypaging.php.

Now an idea: By now the links for Prev/Next contain the titles of the corresponding entries. I think it will be good idea the user to be allowed to select from these and from standard 'Previous' and 'Next' strings (or even arrows). Whenever, the titles are very long and do not fit on one line.

Re: serendipity_event_entrypaging plugin

Posted: Wed Oct 26, 2005 11:13 am
by garvinhicking
Hi!
1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.
Hm, this works here properly using serendipity 0.9-beta3 and the default template.

Only since Serendipity 0.8.5 and 0.9-beta2 or so the "bottom" placement should work in the templates. Which version are you using?
2) Random entry does not appear. It depends on config bool variable 'showrandom' that is fetched from the database (line 164 of serendipity_event_entrypaging.php), but I did not see where it is user-accessible -- even in other parts of s9y.
That was a bug. Thanks, fixed. :)
3) The constant PLUGIN_ENTRYPAGING_BOTTOM is misspelled: PLUGIN_PENTRYPAGING_BOTTOM. This is in lang_de.inc.php and at line 47 of serendipity_event_entrypaging.php.
Fixed as well, thanks!
Now an idea: By now the links for Prev/Next contain the titles of the corresponding entries. I think it will be good idea the user to be allowed to select from these and from standard 'Previous' and 'Next' strings (or even arrows). Whenever, the titles are very long and do not fit on one line.
That's a good idea, I've committed customization of the prev/next text as well.

Regards,
Garvin

Re: serendipity_event_entrypaging plugin

Posted: Wed Oct 26, 2005 11:42 am
by JWalker
garvinhicking wrote:Hi!
1) The Prev/Next links do not appear anywhere when selected to appear at the bottom of the entry. I tried this with 'sudan' theme and the theme that s9y comes with.
Hm, this works here properly using serendipity 0.9-beta3 and the default template.

Only since Serendipity 0.8.5 and 0.9-beta2 or so the "bottom" placement should work in the templates. Which version are you using?
I use 0.9beta1. But will wait for official release of 0.9 and will try again then to see what is the matter.

Posted: Wed Oct 26, 2005 4:56 pm
by judebert
Perhaps it would be worthwhile to restrict the navigation to the current category, as well?

Or should I implement that with a Smarty-parsed static block?