Static pages doesn't use fckeditor plugin in version 3.

Creating and modifying plugins.
Post Reply
grayprog

Static pages doesn't use fckeditor plugin in version 3.

Post by grayprog »

I see plain text edit box. In previous version (2.13), it worked ok.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Static pages doesn't use fckeditor plugin in version 3.

Post by garvinhicking »

Thanks for reporting this!

I just fixed this in version 3.01 of the plugin, here's the patch if you already want to apply it on your own

Code: Select all

Index: ChangeLog
===================================================================
RCS file: /cvsroot/php-blog/additional_plugins/serendipity_event_staticpage/ChangeLog,v
retrieving revision 1.2
diff -u -r1.2 ChangeLog
--- ChangeLog	10 Oct 2005 11:01:59 -0000	1.2
+++ ChangeLog	14 Oct 2005 10:36:58 -0000
@@ -1,3 +1,9 @@
+3.01:
+==============================
+
+Changes by Garvin Hicking:
+* Fixed WYSIWYG editors (to properly work in non-WYSIWYG mode you need Serendipity >= 0.9-beta3!)
+
 3.0:
 ==============================
 
Index: serendipity_event_staticpage.php
===================================================================
RCS file: /cvsroot/php-blog/additional_plugins/serendipity_event_staticpage/serendipity_event_staticpage.php,v
retrieving revision 1.46
diff -u -r1.46 serendipity_event_staticpage.php
--- serendipity_event_staticpage.php	10 Oct 2005 11:01:59 -0000	1.46
+++ serendipity_event_staticpage.php	14 Oct 2005 10:36:59 -0000
@@ -106,7 +106,7 @@
         $propbag->add('page_configuration', $this->config);
         $propbag->add('type_configuration', $this->types_config);
         $propbag->add('author', 'Marco Rinck, Garvin Hicking, David Rolston, Falk Doering');
-        $propbag->add('version', '3.0');
+        $propbag->add('version', '3.01');
         $propbag->add('requirements',  array(
             'serendipity' => '0.8',
             'smarty'      => '2.6.7',
@@ -954,7 +954,7 @@
                     echo '<div class="serendipityAdminMsgSuccess">'. DONE .': '. sprintf(RIP_ENTRY, $this->pagetype['description']) . '</div>';
                 }
 
-                echo '<form action="serendipity_admin.php" method="post" name="editStaticPages">';
+                echo '<form action="serendipity_admin.php" method="post" name="serendipityEntry">';
                 echo '<div>';
                 echo '  <input type="hidden" name="serendipity[adminModule]" value="event_display" />';
                 echo '  <input type="hidden" name="serendipity[adminAction]" value="staticpages" />';
@@ -1020,7 +1020,7 @@
                     }
                 }
 
-                echo '<form action="serendipity_admin.php" method="post" name="editStaticPages">';
+                echo '<form action="serendipity_admin.php" method="post" name="serendipityEntry">';
                 echo '<div>';
                 echo '  <input type="hidden" name="serendipity[adminModule]" value="event_display" />';
                 echo '  <input type="hidden" name="serendipity[adminAction]" value="staticpages" />';
@@ -1400,24 +1400,24 @@
         if (!$serendipity['wysiwyg'] && eregi($serendipity['EditorBrowsers'], $_SERVER['HTTP_USER_AGENT']) ) {
 ?><nobr>
                   <script type="text/javascript" language="JavaScript">
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insI" value="I" accesskey="i" style="font-style: italic" onclick="wrapSelection(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<i>\',\'</i>\')" />');
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insB" value="B" accesskey="b" style="font-weight: bold" onclick="wrapSelection(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<b>\',\'</b>\')" />');
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insU" value="U" accesskey="u" style="text-decoration: underline;" onclick="wrapSelection(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<u>\',\'</u>\')" />');
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insQ" value="<?php echo QUOTE ?>" accesskey="q" style="font-style: italic" onclick="wrapSelection(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<blockquote>\',\'</blockquote>\')" />');
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insJ" value="img" accesskey="j" onclick="wrapInsImage(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'])" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insI" value="I" accesskey="i" style="font-style: italic" onclick="wrapSelection(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<i>\',\'</i>\')" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insB" value="B" accesskey="b" style="font-weight: bold" onclick="wrapSelection(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<b>\',\'</b>\')" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insU" value="U" accesskey="u" style="text-decoration: underline;" onclick="wrapSelection(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<u>\',\'</u>\')" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insQ" value="<?php echo QUOTE ?>" accesskey="q" style="font-style: italic" onclick="wrapSelection(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'],\'<blockquote>\',\'</blockquote>\')" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insJ" value="img" accesskey="j" onclick="wrapInsImage(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'])" />');
                         document.write('<input type="button" class="serendipityPrettyButton" name="insImage" value="<?php echo MEDIA; ?>" style="" onclick="window.open(\'serendipity_admin_image_selector.php?serendipity[textarea]=<?= urlencode('serendipity[plugin]['.$config_item.']'); ?>\', \'ImageSel\', \'width=800,height=600,toolbar=no,scrollbars=1,scrollbars,resize=1,resizable=1\');" />');
-                        document.write('<input type="button" class="serendipityPrettyButton" name="insU" value="URL" accesskey="l" style="color: blue; text-decoration: underline;" onclick="wrapSelectionWithLink(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'])" />');
+                        document.write('<input type="button" class="serendipityPrettyButton" name="insU" value="URL" accesskey="l" style="color: blue; text-decoration: underline;" onclick="wrapSelectionWithLink(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'])" />');
                   </script></nobr>
 <?php
         /* Do the "old" non-WYSIWYG editor */
         } elseif (!$serendipity['wysiwyg']) { ?><nobr>
                   <script type="text/javascript" language="JavaScript">
-                        document.write('<input type="button" class="serendipityPrettyButton" value=" B " onclick="serendipity_insBasic(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'b\')">');
-                        document.write('<input type="button" class="serendipityPrettyButton" value=" U " onclick="serendipity_insBasic(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'u\')">');
-                        document.write('<input type="button" class="serendipityPrettyButton" value=" I " onclick="serendipity_insBasic(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'i\')">');
-                        document.write('<input type="button" class="serendipityPrettyButton" value="<img>" onclick="serendipity_insImage(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'])">');
+                        document.write('<input type="button" class="serendipityPrettyButton" value=" B " onclick="serendipity_insBasic(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'b\')">');
+                        document.write('<input type="button" class="serendipityPrettyButton" value=" U " onclick="serendipity_insBasic(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'u\')">');
+                        document.write('<input type="button" class="serendipityPrettyButton" value=" I " onclick="serendipity_insBasic(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'], \'i\')">');
+                        document.write('<input type="button" class="serendipityPrettyButton" value="<img>" onclick="serendipity_insImage(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'])">');
                         document.write('<input type="button" class="serendipityPrettyButton" value="<?php echo MEDIA; ?>" onclick="window.open(\'serendipity_admin_image_selector.php?serendipity[filename_only]=<?= $config_item ?>\', \'ImageSel\', \'width=800,height=600,toolbar=no\');">');
-                        document.write('<input type="button" class="serendipityPrettyButton" value="Link" onclick="serendipity_insLink(document.forms[\'editStaticPages\'][\'serendipity[plugin][<?= $config_item ?>]\'])">');
+                        document.write('<input type="button" class="serendipityPrettyButton" value="Link" onclick="serendipity_insLink(document.forms[\'serendipityEntry\'][\'serendipity[plugin][<?= $config_item ?>]\'])">');
                 </script></nobr>
 <?php   }
 
@@ -1435,7 +1435,7 @@
         <tr>
             <td colspan="2">
                 <div>
-                    <textarea class="direction_<?php echo $lang_direction; ?>" style="width: 100%" id="serendipity[plugin][<?= $config_item ?>]" name="serendipity[plugin][<?= $config_item; ?>]" rows="20" cols="80"><?php echo $hvalue; ?></textarea>
+                    <textarea class="direction_<?php echo $lang_direction; ?>" style="width: 100%" id="nuggets<?php echo $elcount; ?>" name="serendipity[plugin][<?= $config_item; ?>]" rows="20" cols="80"><?php echo $hvalue; ?></textarea>
                 </div>
             </td>
         </tr>
Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply