Serendipity Forums

After one of the latest updates, clicking "valid" in comments now gives me a white page saying nothing but "Done." ("Fertig." in German)

Bug or just a weird caching thing on my end?

YL

No, by design, until found something better, as I understood Malte.

But it should only happen when JS is deactivated.

I assure you, it's not.

YL

Is there an error-message in the console? Which browser do you use? It seems to work fine on my system.

Edit: Oh, an update was missing on my blog and indeed it's not working properly. I'll look into it.

No, nothing in the console whatsoever.

However, the url of the blank page is

[blog url]/index.php?/plugin/learnAction&action=approve&category=ham&id=XXX&entry_id=YY

Shouldn't it be /serendipity_admin.php?[…] or something?

YL

No, it's a normal event-hook, only checking for admin-rights internally. The preventDefault() isn't working properly, the browser shouldn't follow the link.

onli wrote:The preventDefault() isn't working properly, the browser shouldn't follow the link.

Typo? (The missing ";".) Try moving the preventDefault() statement to the end of the associated code block. If everything else fails, try good old "return false" instead.

YL

I just tested it again, wanting to fix it, and this time everything worked (in chrome and ff, in my real and in my testblog). Maybe this was a caching-issue?
I noticed it already uses the return-false-approach. It really should already work, semicolon or not. Would someone of you please test that? :)

onli wrote:Maybe this was a caching-issue?

Hm. Yes. Sorry. I always thought, Ctrl + Shift + r would suffice to bypass caching, but apparently not. After cleaning out the browser cache, it works the way it's supposed to. Weird.

YL