Page 1 of 1
Prevent empty body & extended body in entrycheck_plugin
Posted: Tue Jan 31, 2012 5:26 pm
by gregman
Hi there,
as mentioned in the subject, I added two new options to the entry_check plugin; one for preventing empty entry bodies, one for preventing empty extended bodies. German, english and frensh language files updated as well. Maybe someone's gonna need these features too. Shall I upload it anywhere?
Regards
Greg
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Tue Jan 31, 2012 6:55 pm
by yellowled
gregman wrote:as mentioned in the subject, I added two new options to the entry_check plugin; one for preventing empty entry bodies, one for preventing empty extended bodies. German, english and frensh language files updated as well. Maybe someone's gonna need these features too. Shall I upload it anywhere?
Sounds promising. Usually, Garvin and the coder guys prefer a diff (a file compaing the changes made compared to the current version). Can you provide a diff file? (I think it has to be a unified diff, but I'm not 100% sure.)
YL
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Wed Feb 01, 2012 9:48 am
by gregman
Is there an app for this?
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Wed Feb 01, 2012 11:45 am
by yellowled
gregman wrote:Is there an app for this?
Depends on your OS.
YL
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Wed Feb 01, 2012 1:49 pm
by garvinhicking
Hi!
The complete ZIP file would also do. Preferably linked on a public URL so I can wget it, which makes updating it much more easy instead of needing to first extract a ZIP from an email, save it to disk, upload it to my server, and extract it there
Regards,
Garvin
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Thu Feb 02, 2012 10:51 am
by gregman
Hi Garvin,
here it is:
http://www.studium-auskunft.de/uploads/ ... ycheck.zip
As I experienced some weired behavior I had to fix some bugs too. Hope everything is working now.
Regards
Greg
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Thu Feb 02, 2012 7:56 pm
by garvinhicking
Hi!
Great. I saw you changed the boolean logic of the checks? That's odd, somebody should have noticed that, if the logic were inverted? Anyhow, I trust you to have checked that and got it working for you, so I committed your patch. Thanks a lot!
Regards,
Garvin
Re: Prevent empty body & extended body in entrycheck_plugin
Posted: Thu Feb 02, 2012 10:41 pm
by gregman
Yes, this was IMHO a bug. In the language files it says e.g.
Code: Select all
@define('PLUGIN_EVENT_ENTRYCHECK_EMPTYTITLE', 'Do not allow empty titles');
@define('PLUGIN_EVENT_ENTRYCHECK_EMPTYTITLE_DESC', 'If set to "true", an entry must not have an empty title.');
So you have to prevent saving the entry, if the config variables are set to true.
Regards,
Greg
EDIT: P.S.: I'm done with the ajax enhancement of the karma_plugin,
http://board.s9y.org/viewtopic.php?f=11 ... #p10429061