i18n issues with notifications texts (in E-mail)
Posted: Sun May 15, 2011 12:31 pm
I had to say that text in e-mail notifications is bad (from internationalization POV), and it's strange for me, because my very poor German tells me "In Deutsch Literatur at least 'User Name' from English also will not be 2-word combination, but just "Benutzernamen" and trouble must be detected earlier"
In short
Combine phrases (for comment and trackback notify) from separate words (OBJECT and ATTRIBUTE is dirty for many languages (I suppose), it sounds like a rough equivalent of smth. like "Ich stand und die Leute beobachten" in German. Phrases must be translated as phrases in context in my case
serendipity_sendComment() in include/functions_comments.inc.php
str. 1121
is bad twice:
1. hardcoded "Weblog" (must be WEBLOG from lang)
2. pair WEBLOG.' '.NAME (must be reversed and noun WEBLOG used in the genitive instead of nominative)
str. 1142-1145 have the same problem N2 as 1121, with obvious correction: noun USER...
Fix is small and easy, I can do it (and 5 new lang-resources and replace old in code), but I think I have to notify for the possible global adjustment
In short
Combine phrases (for comment and trackback notify) from separate words (OBJECT and ATTRIBUTE is dirty for many languages (I suppose), it sounds like a rough equivalent of smth. like "Ich stand und die Leute beobachten" in German. Phrases must be translated as phrases in context in my case
serendipity_sendComment() in include/functions_comments.inc.php
str. 1121
Code: Select all
. "\n" . 'Weblog ' . NAME . ': ' . stripslashes($fromName)1. hardcoded "Weblog" (must be WEBLOG from lang)
2. pair WEBLOG.' '.NAME (must be reversed and noun WEBLOG used in the genitive instead of nominative)
str. 1142-1145
Code: Select all
. "\n" . USER . ' ' . IP_ADDRESS . ': ' . $_SERVER['REMOTE_ADDR']
. "\n" . USER . ' ' . NAME . ': ' . $fromName
. "\n" . USER . ' ' . EMAIL . ': ' . $fromEmail
. "\n" . USER . ' ' . HOMEPAGE . ': ' . $fromUrl
Fix is small and easy, I can do it (and 5 new lang-resources and replace old in code), but I think I have to notify for the possible global adjustment