staticpages 3.83 case 18 failed

Creating and modifying plugins.
Post Reply
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

staticpages 3.83 case 18 failed

Post by Timbalu »

I just updated from 3.80 to 3.83 but the $sql = 'ALTER TABLE '.$serendipity['dbPrefix'].'staticpages ADD COLUMN is_404_page int(1) default 0'; did not add the column.
I noticed this by updating an old entry.

$this->set_config('db_built' jumps from 7 to 19 ... where are the set_configs inbetween?
I just remembered once having problems with the install of the additional staticpages tables too.
Maybe there is a major problem in the db update logic...
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: staticpages 3.83 case 18 failed

Post by garvinhicking »

Hi!

There are no in-betweens, they were removed on each plugin update. It's okay to jump to 19.

I suppose the SQL query failed for you. You might want to edit your serendipity_config entry for the db_built to reset it to 7, then edit the staticpage event file to maybe log the output of mysql_error() after each serendipity_db_schema_import. Maybe your MySQL is older and chokes one a statement? Not all of them were done and checked by me, it could very well be that there's a bug in one of them.

In mysql(i) a "AFTER ..." is appended to the SQL, maybe that could be your issue?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: staticpages 3.83 case 18 failed

Post by Timbalu »

Thank you Garvin.
garvinhicking wrote:I suppose the SQL query failed for you.
In mysql(i) a "AFTER ..." is appended to the SQL, maybe that could be your issue?
Well its a pure debian Lenny system. Pure PHP and MySql in some 5.x versions. I did already solve that little issue by adding it manually, but looking into the code, I couldn't find any reason why it failed (at least here, sometimes). This must be some kind of special case, else a lot of people would complain about it here in the forum. So my thread was more a kind of notice.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Post Reply