Page 1 of 1
problem with Archives Summery Pages (Bulletproof)
Posted: Sun May 02, 2010 1:21 am
by konus
Hello,
I just found out, that the summery pages, my blog generates at the archives (headings only) does not validate at all.
Here is my
summary archives page and here is the
result with validate.w3.org
It looks like, that there are no headings allowed inside description lists? The syntax comes from bulletproof/entries_summary.tpl
How could I change it?
Re: problem with Archives Summery Pages (Bulletproof)
Posted: Sun May 02, 2010 10:50 am
by yellowled
konus wrote:I just found out, that the summery pages, my blog generates at the archives (headings only) does not validate at all.
Yikes. You're right, this needs to be changed in BP. Thanks for noticing
Right now, the entries_summary.tpl's inner foreach loop looks like this:
Code: Select all
<dl class="archive_summary {cycle values='archive_summary_odd,archive_summary_even'}">
<h4 class="archive_summary_title"><a href="{$entry.link}">{$entry.title|truncate:80:" ..."}</a></h4>
<dt class="archive_summary_postdate">{$entry.timestamp|@formatTime:$template_option.date_format}</dt>
<dd class="archive_summary_postdetails">
{if $template_option.footerauthor == 'true'}
{$CONST.POSTED_BY} <address class="author"><a href="{$entry.link_author}">{$entry.author}</a></address>
{/if}
{if $template_option.footercategories == 'true'}
{if $entry.categories}
{$CONST.IN} {foreach from=$entry.categories item="entry_category" name="categories"}<a href="{$entry_category.category_link}">{$entry_category.category_name|@escape}</a>{if not $smarty.foreach.categories.last}, {/if}{/foreach}
{/if}
{/if}
</dd>
</dl>
You can change this to
Code: Select all
<dl class="archive_summary {cycle values='archive_summary_odd,archive_summary_even'}">
<dt class="archive_summary_title"><a href="{$entry.link}">{$entry.title|truncate:80:" ..."}</a></dt>
<dd class="archive_summary_postdate">{$entry.timestamp|@formatTime:$template_option.date_format}</dd>
{if $template_option.footerauthor == 'true' or $template_option.footercategories == 'true'}
<dd class="archive_summary_postdetails">
{if $template_option.footerauthor == 'true'}
{$CONST.POSTED_BY} <address class="author"><a href="{$entry.link_author}">{$entry.author}</a></address>
{/if}
{if $template_option.footercategories == 'true'}
{if $entry.categories}
{$CONST.IN} {foreach from=$entry.categories item="entry_category" name="categories"}<a href="{$entry_category.category_link}">{$entry_category.category_name|@escape}</a>{if not $smarty.foreach.categories.last}, {/if}{/foreach}
{/if}
{/if}
</dd>
{/if}
</dl>
I'll commit these changes to svn ASAP.
YL
Re: problem with Archives Summery Pages (Bulletproof) (solved)
Posted: Sun May 02, 2010 8:47 pm
by konus
Thank you for the help, now everything is correct!
I am always amazed about the speed and the quality of the help in this community!
Greetings Konus
Re: problem with Archives Summery Pages (Bulletproof) (solved)
Posted: Sun May 02, 2010 10:44 pm
by yellowled
konus wrote:Thank you for the help, now everything is correct!
You're welcome. You might wanna add a
Code: Select all
.archive_summary dd { margin-left: 0; }
to a suitable CSS file to fix the indentation, though
YL
Re: problem with Archives Summery Pages (Bulletproof)
Posted: Tue May 04, 2010 9:54 pm
by konus
Thank you, now it looks even better!