Page 1 of 1

No "paging" in media db

Posted: Thu Oct 29, 2009 6:34 pm
by yellowled
Hohum. I just noticed that if I click "Next" in the media db overview, the media db, well, doesn't go to the next page. The URL changes from i.e.

Code: Select all

/serendipity_admin.php?serendipity[adminModule]=media
to

Code: Select all

/serendipity_admin.php?serendipity[adminModule]=media&serendipity[sortorder][perpage]=&serendipity[sortorder][order]=&serendipity[sortorder][ordermode]=&serendipity[page]=2
but I still get the same images displayed as on page 1.

This is the latest revision (2592) from svn running on a local Ubuntu lamp (PHP 5.2.6).

Bug or quirk in my local installation?

YL

Re: No "paging" in media db

Posted: Thu Oct 29, 2009 7:19 pm
by garvinhicking
Hi!

A very good catch. This was introduced by a patch that changed the image workflow to redirect to the overview after upload. Another sideeffect of this has also been fixed just recently, and I now also committet the fix for the behaviour you reported.

MANY thanks for that one, I'm glad we hadn't released 1.5 yet :)

Regards,
Garvin

Re: No "paging" in media db

Posted: Thu Oct 29, 2009 7:26 pm
by yellowled
garvinhicking wrote:MANY thanks for that one, I'm glad we hadn't released 1.5 yet :)
Me too :) Funny no one noticed, though. Quite a lot of people seem to use 1.5betaX already. Guess this isn't something one stumbles upon easily.

YL

Re: No "paging" in media db

Posted: Thu Oct 29, 2009 8:46 pm
by onli
Puh, thanks yellowled. Quite a lot of bugs I introduced with that one, sorry (haven't noticed that because there are not enough images in my testenvironment - yet. And simply wasn't aware of that behavior).

Re: No "paging" in media db

Posted: Thu Oct 29, 2009 9:43 pm
by garvinhicking
Hi!

No harm done, we caught it before the spotlight :)

Re: No "paging" in media db

Posted: Fri Oct 30, 2009 9:06 pm
by Don Chambers
I do not know if this is related or not.... Running latest 1.5 beta via SVN and php 5.3.0:

Create/edit an entry.
Click on button to insert something from the media library.
Image is not yet in my media library, so select "add media".

Returned to the edit entry page with this the only thing inserted into the entry:

Code: Select all

<a href="" title="" target="_blank"></a>
Something else, which may have never worked for all I know:

Create/edit an entry.
Click on button to insert something from the media library.
Before selecting an image, delete an existing image.
Button to add media is no longer present once an existing image has been deleted.

Re: No "paging" in media db

Posted: Sat Oct 31, 2009 1:40 pm
by onli
The empty insert is something that's not happening on my local installation with the changes I made to this, so this is not necessarily related. But I'll try the latest version and see if that is connected anyway, it could be it's part of the latest changes to fix "my" bug.

Re: No "paging" in media db

Posted: Mon Nov 02, 2009 11:44 am
by onli
Tested with the last snapshot, I can't reproduce the error you described, Don. Can you test that again, if it's still present and if yes, maybe describe it again?

Re: No "paging" in media db

Posted: Mon Nov 02, 2009 3:36 pm
by Don Chambers
Create an entry.
Insert an image via the "Media" button (non wysiwyg editor)
Instead of selecting an existing image, upload one via "Add Media" button.
Browse your computer, select image, then "Go" to upload the image.

Image is uploaded, but you are never given an opportunity to select the large or thumbnail version, and the image is NOT inserted. What is inserted into the entry is just:

Code: Select all

<a href="" title="" target="_blank"></a>

Re: No "paging" in media db

Posted: Mon Nov 02, 2009 4:48 pm
by onli
Thanks. This error is definitely not present with the last snapshot on my installation. I get the option to select the whole image or a thumbnail and the insert works correct. Can anyone else reproduce this?

Re: No "paging" in media db

Posted: Mon Nov 02, 2009 7:55 pm
by yellowled
onli wrote:Can anyone else reproduce this?
Just tried it as Don suggested -- works fine with a recent snapshot in Firefox 3.5.4. The reason I'm pointing this out is that I know Don still uses FF2 or IE -- maybe that's the reason it doesn't work for him ..?

YL

Re: No "paging" in media db

Posted: Tue Nov 03, 2009 10:22 am
by garvinhicking
Hi!

For me as well this works properly with the recent snapshot!

(FF3, but should be unrelated)

Regards,
Garvin