"Freetag"- and "Start Page Configuration"-Problem

[chessnut]

I installed the "Start Page Configuration"-Plugin.

Scenario: 2 Categories: "fruits" and "cars". Fruits is the category shown on the front page.
fruits-category has 2 entries tagged with tag "red"
cars-category has 1 entry tagged with tag "red"

Problems:
-On the frontpage the freetag-sidebar-plugin shows "red (3)" instead of "red (2)".
-When I click the link "red (3)" which calls "index.php?/plugin/tag/red" it shows "No entries to print"

Is there any explanation for this behaviour? I looked through the event_hook of freetag, but could find no explanation. Especially the second problem is rather awkward.

Thanks in advance for any help!

[garvinhicking]

Hi!

Yes, the freetag sidebar plugin display is completely independent from categories. That part comes "by design".

Actually the link red(3) should show you 2 entries from inside the fruits category. This is because the startpage-category plugin fixates the category, and the freetag plugin modifies the internal s9y core query in a way that uses all usual restrictions and adds its tag output. Why in your case nothing is shown, is strange. I assume all works when you disable the startpage plugin?

The freetag plugins includes the "genpage" plugin which then calls the serendipity_fetchEntries() PHP function. Maybe you could check the include/functions_entries.inc.php file, search for the function and temporarily remove the "//" in front of "die($query)". This way you can let yourself display the SQL query that the plugin uses when you call the index.php?/plugin/tag/red link, and when you show it to me, I could easier debug this. ATM I don't have the time to setup a sandbox with those specific surroundings you described...

Regards,
Garvin

[chessnut]

Actually the link red(3) should show you 2 entries from inside the fruits category. [...]Why in your case nothing is shown, is strange.

Sorry, I was wrong. All 3 entries are in category "cars" which is not shown on the frontpage. So the behavior is formally correct.
But for the user the behavior is absolutely not correct. He sees "red(3)", clicks on it and gets the message "No entries to print".

So I did a quick fix, so the freetag-plugin works as I expect it to work. I added in the serendipity_event_freetag.php following line in the event_hook-method after "global $serendipity;":

Code: Select all

$serendipity['GET']['category'] = 'all';

@Garvin: The behavior described above is more than confusing. I suggest to add the code-line above permanently to the freetag-plugin, which would improve the freetag-plugin for admins with the start-page-configuration-plugin installed and make no difference for normal admins. Because as you said "the freetag sidebar plugin display is completely independent from categories".
How do you feel about this suggestion?

[garvinhicking]

Hi!

Thanks, I've commited a fix so that the category variable now gets unset for these cases. I agree that this behaviour is a bit odd.

Regards,
Garvin