Page 1 of 1

jQuery-Plugin

Posted: Sat Apr 25, 2009 1:11 pm
by onli
There are two points of the jquery-plugin I wanted to discuss.

1. Instead of updating it every time a new version is released we could use Google to deliver the newest version. As an additional advantage Google's minimized and gzipped version is smaller than the one I incorporated so far. I attached a version which works that way.

2. There are now two reports (1, 2) that the automatic installation of the Plugin didn't work the first time. Maybe the dependency-system is used wrong? Can someone have a look?

Re: jQuery-Plugin

Posted: Sat Apr 25, 2009 4:47 pm
by stm999999999
onli wrote: 2. There are now two reports (1, 2) that the automatic installation of the Plugin didn't work the first time.
as I wrote:
IIRC there was for some times another js-libs-plugin, and I tested both and deinstalled both, because I do not know the comment-dependency
But it would be nice for a plugin, which need jquery, to give a short notice about the dependency to the admin in the plugin-description

Re: jQuery-Plugin

Posted: Sat Apr 25, 2009 4:51 pm
by onli
I don't think so. If a plugin needs another dependency, it should not be possible to uninstall the dependency.

Re: jQuery-Plugin

Posted: Sat Apr 25, 2009 5:03 pm
by stm999999999
I mean:

1. my report "problem with automatic installation" seems to be wrong

2. is it a good idea to make a unable-to-uninstall dependency when there could be another jquery-plugin? As I mentioned there was a second one which I tried:

serendipity_event_jslibs

Code: Select all

jQuery 1.4 
 Bibliothek in Serendipity einbinden 	 
jQuery Plugins 
 Liste zusätzlicher Plugins (getrennt durch Komma) 	 
mootools 1.11 
 Bibliothek in Serendipity einbinden 	 
Prototype 1.5.1.1

Re: jQuery-Plugin

Posted: Sat Apr 25, 2009 7:09 pm
by onli
Oh. Well, it's obvious wasn't aware of that :)
I see your point. Instead of make it impossible a hint should appear if there still is something depending on it.

You didn't experienced any problems with the google-jquery-plugin, did you?

Re: jQuery-Plugin

Posted: Sun Apr 26, 2009 5:03 pm
by stm999999999
in the moment I can't see any problem

Re: jQuery-Plugin

Posted: Fri Jun 05, 2009 12:18 am
by onli
Testing this quite a while from time to time at my local installation this really seems to work well. Can we now use this version globally?
sincerely

Re: jQuery-Plugin

Posted: Fri Jun 05, 2009 10:20 am
by garvinhicking
Hi!

Would you like Spartacus/CVS write access to commit it? If you create/have a sourceforge.net username, I can add you.

Regards,
Garvin

Re: jQuery-Plugin

Posted: Fri Jun 05, 2009 11:36 am
by onli
The username is "onli". If that would save some parts of your time I'd do it.
sincerely

Re: jQuery-Plugin

Posted: Fri Jun 05, 2009 4:11 pm
by garvinhicking
Hi!

that would be awesome! I added you to the list, so you should be able to check out the "additional_plugins" module from the CVS SourceForge service and add your plugin! then it will get added on the next spartacus cycle on the next day.

Regards
Garvin

Re: jQuery-Plugin

Posted: Tue Jun 09, 2009 2:42 pm
by onli
Hi
I updated the jquery_plugin a minute ago. Hope everything worked fine :)
sincerely