content.tpl

[yellowled]

Two questions about this part of the default content.tpl:

Code: Select all

{if $searchresult_tooShort}
    <h3 class="serendipity_date">{$CONST.QUICKSEARCH}</h3>
    <div class="serendipity_search serendipity_search_tooshort">{$content_message}</div>
{elseif $searchresult_error}
    <h3 class="serendipity_date">{$CONST.QUICKSEARCH}</h3>
    <div class="serendipity_search serendipity_search_error">{$content_message}</div>
{elseif $searchresult_noEntries}
    <h3 class="serendipity_date">{$CONST.QUICKSEARCH}</h3>
    <div class="serendipity_search serendipity_search_noentries">{$content_message}</div>
{elseif $searchresult_results}
    <h3 class="serendipity_date">{$CONST.QUICKSEARCH}</h3>
    <div class="serendipity_search serendipity_search_results">{$content_message}</div>
{else}
    <div class="serendipity_content_message">{$content_message}</div>
{/if}

1. As far as I have worked with s9y so far, {$content_message} is always empty if no search has been done. That means that the last part will always emit an empty div. Are there actually cases where it is not empty apart from the various search result cases before?

2. If one would not need the individual classes for the various search results, would it cause any issues to shorten the code above like this?

Code: Select all

{if $searchresult_tooShort or $searchresult_error or $searchresult_noEntries or $searchresult_results}
    <dl>
        <dt>{$CONST.QUICKSEARCH}</dt>
        <dd>{$content_message}</dd>
    </dl>
{else}
{/if}

YL

[garvinhicking]

Hi!

1. Yes, Plugins may use this.

2. Yes, that's okay.

Regards,Garvin

[Don Chambers]

YL - if your only concern is emitting an empty div, why not just make that last one an {elseif $content_message} ? You can still do your definition list structure.... but at least you will not be emitting an empty container.

[yellowled]

YL - if your only concern is emitting an empty div, why not just make that last one an {elseif $content_message} ?

Because that didn't even cross my mind Very smart, though. Thanks.

YL