Page 1 of 2
Ported: Aerodrome 1.0
Posted: Tue Dec 09, 2008 12:17 am
by sonichouse
I have taken on my first full port, and am currently testing it.
I would welcome some critical eyes to look over my efforts so far.
The test link is
here.
I will bundle up a release package once I have ironed out the remaining wrinkles.
A link to the original author is in the credits of the footer of my test page.
It has been a good learning experience, especially working out how to do nested comments gracefully.
Gravatar support has been added, and works better if you tell the plugin to emit smarty code, or, if not, set the gravatar to float:right.
Can't wait ....
/Steve
Posted: Tue Dec 09, 2008 4:03 am
by Don Chambers
Congrats Steve!!! Keep up the fantastic work!
I am half dead tonight having had a really rough past few days, however, a quick check in IE6 shows some problems.
Add this to .storywrap: {display:inline}. This will get you out of IE's margin doubling bug on floated elements (google if you need more info).
You also need to trigger haslayout on the <p> containing the page footer (page 1 of x totalling y entries).... my first suggestion would be position: relative.... there are lots of ways to trigger it, but I get away with that 99% of the time.
My personal preference is that the "reply" link in comments is too large - again, my personal preference.
Finally, run a validator against the css, not just the html...... tons of errors there, but they may be beyond your control since they were probably inherited in the port process.
Re: Ported: Aerodrome 1.0
Posted: Tue Dec 09, 2008 11:25 am
by yellowled
sonichouse wrote:I have taken on my first full port, and am currently testing it.
Way to go, Steve!
There is a margin between the headmenu ul and the actual header, which is noticable to the human eye even in FF. The entry footer needs work, too, but that depends a little on how close you're trying to get to the original.
As for the IE fixes, I usually go with Don's suggestions myself, he's got a knack for those
YL
Posted: Tue Dec 09, 2008 1:12 pm
by sonichouse
Don Chambers wrote:Congrats Steve!!! Keep up the fantastic work!
Thanks Don, might be my first and last one too !!!
Don Chambers wrote:Add this to .storywrap: {display:inline}.
Done.
Don Chambers wrote:You also need to trigger haslayout on the <p> containing the page footer (page 1 of x totalling y entries).... my first suggestion would be position: relative.... there are lots of ways to trigger it, but I get away with that 99% of the time.
OK, added but can't test. You have just got to love this cross-browser stuff.
Don Chambers wrote:My personal preference is that the "reply" link in comments is too large - again, my personal preference.
Agreed, toned them down a bit.
Don Chambers wrote:Finally, run a validator against the css, not just the html...... tons of errors there, but they may be beyond your control since they were probably inherited in the port process.
The CSS has quite a few browser hacks for moz to add rounded corners etc which do not validate, but as you say I inherited most of them
Re: Ported: Aerodrome 1.0
Posted: Tue Dec 09, 2008 1:15 pm
by sonichouse
yellowled wrote:There is a margin between the headmenu ul and the actual header, which is noticable to the human eye even in FF. The entry footer needs work, too, but that depends a little on how close you're trying to get to the original.
Thanks YL for your support.
The entry footer has a makeover - it was way to big !!
The headmenu is the same as the original template by the author.
I am not completely sold on the idea of the margin either
Posted: Tue Dec 09, 2008 3:13 pm
by Don Chambers
Much better Steve.....
Only remaining comment is the pipe character before your categories...
Looks like you are always showing the categories for an entry on a line before the author and date.... the pipe character, often uses as a separator, does not really make a lot of sense in that context IMHO.... but, again, these are all personal judgement calls.
Great job!
Posted: Tue Dec 09, 2008 3:55 pm
by sonichouse
Don Chambers wrote:Much better Steve.....
Only remaining comment is the pipe character before your categories...
Looks like you are always showing the categories for an entry on a line before the author and date.... the pipe character, often uses as a separator, does not really make a lot of sense in that context IMHO.... but, again, these are all personal judgement calls.
Great job!
Thanks Don - much appreciated.
Is my web cam on ? - you seem to be looking over my shoulder just as I attack an issue
. The category thing is done, as well as tidying up the nested comments.
Posted: Wed Dec 10, 2008 7:22 am
by akremedy
Looks great Steve - I'm posting this comment that I left for you here at the S9Y forum too ... is anyone else seeing this behavior in FF3 in the Comments box?
Steve, there's something goofy with FF3 as I type in this text box. The text itself is almost so light as to be invisible (except that every once in awhile, a letter will show up, then become very light on the next keystroke. Minimizing and maximizing the browser "fixes" it, but only until the next keystroke. This behavior doesn't exist in IE7. I think there is a transparency or alpha issue in FF. Otherwise, it's a great layout!
Posted: Wed Dec 10, 2008 10:55 am
by sonichouse
akremedy wrote:Steve, there's something goofy with FF3 as I type in this text box. The text itself is almost so light as to be invisible (except that every once in awhile, a letter will show up, then become very light on the next keystroke. Minimizing and maximizing the browser "fixes" it, but only until the next keystroke. This behavior doesn't exist in IE7. I think there is a transparency or alpha issue in FF. Otherwise, it's a great layout!
Thanks for that I was testing in FF2, so after I installed FF3 I also get the problem.
The fix is
Code: Select all
#commentform textarea {background-color: inherit;}
Not entirely happy, but then again, I don't fully understand what is going on either
Posted: Wed Dec 10, 2008 3:33 pm
by judebert
Holy cow, that's a fantastic theme! I had to work hard to see it, because my computer can't access anything but port 80; I had to set up a proxy server. But it was worth it!
Great job!
Posted: Wed Dec 10, 2008 4:35 pm
by sonichouse
judebert wrote:Holy cow, that's a fantastic theme! I had to work hard to see it, because my computer can't access anything but port 80; I had to set up a proxy server. But it was worth it!
Great job!
Thanks nearly there, I have a few minor tweaks to make, and then I may consider it complete.
BTW the site should be visible on port 80.
Posted: Wed Dec 10, 2008 10:38 pm
by judebert
sonichouse wrote:BTW the site should be visible on port 80.
The main site is, but the devblog apparently uses port 8008 for CSS (since I'm getting unstyled HTML), and the Aerodrome link is definitely using port 8008.
Posted: Thu Dec 11, 2008 11:19 am
by sonichouse
The zip for the theme is now available for public consumption.
Thanks to YellowLed, Don, and Judebert for their patience and guidance, without whom I wouldn't have got this far.
More details and download files can be found in my
blog article
Feedback and bug reports all welcome
Posted: Thu Dec 11, 2008 12:26 pm
by yellowled
sonichouse wrote:Thanks to YellowLed, Don, and Judebert for their patience and guidance, without whom I wouldn't have got this far.
You're welcome
Hate to break it to you, but the textarea in the comment form is wider than its container which means it breaks out of the bg image ...
Plus, I can't seem to get past your comment captcha. L'il fucker always gives me a 500 error.
YL
Posted: Thu Dec 11, 2008 1:13 pm
by sonichouse
yellowled wrote:You're welcome
Hate to break it to you, but the textarea in the comment form is wider than its container which means it breaks out of the bg image ...
Plus, I can't seem to get past your comment captcha. L'il fucker always gives me a 500 error.
YL
1. Padding was missing from the comment form - fixed
2. Contacted Akismet - waiting for a reply
