Page 1 of 1

Comments Bug V 1.4 Beta1

Posted: Sat Dec 06, 2008 7:43 pm
by Kilrathi
I installed the 1.4 Beta1 version and discovered a bug in the comments function. After adding the comment an error page appears.

The comment is submitted correctly and appears under the posting. But this error page is quiet irritating for the users.
Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.
Please contact the server administrator, webmaster and inform them of the time the error occurred, and anything you might have done that may have caused the error.
More information about this error may be available in the server error log.
Additionally, a 500 Internal Server Error error was encountered while trying to use an ErrorDocument to handle the request.

Re: Comments Bug V 1.4 Beta1

Posted: Sat Dec 06, 2008 8:31 pm
by yellowled
Kilrathi wrote:I installed the 1.4 Beta1 version and discovered a bug in the comments function.
The current beta is 1.4-beta2. Could you upgrade to that version and see if the error still occurs?

Also see http://blog.s9y.org/archives/201-For-1. ... sters.html.

YL

Posted: Sat Dec 06, 2008 8:45 pm
by Kilrathi
Where can I find the new version? On the bottom of the download site?
Document s9y_200812052342.tar.gz yesterday, 23:42, 4.96 MB
Is this the right one?

At the top I can only find the beta1

Posted: Sat Dec 06, 2008 8:53 pm
by yellowled
Kilrathi wrote:
Document s9y_200812052342.tar.gz yesterday, 23:42, 4.96 MB
Is this the right one?
Yes, that's the latest nightly snapshot. You can even see the creation date in the filename (2008-12-05, 23:42).

YL

Posted: Sat Dec 06, 2008 9:22 pm
by Kilrathi
*update*

I installed the beta2 in a new folder and the comments bug is still there. I now will try 1.3.


Now all is broken down.

The following messages and a lot mire like these are displayed when I try to install the new version.

I hope I can successful downgrade to 1.3

fehlgeschlagenlang/plugin_lang.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/addlang.txt beschädigt oder verändert: Überprüfung fehlgeschlagenlang/serendipity_lang_sa.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/serendipity_lang_en.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/serendipity_lang_se.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/serendipity_lang_cs.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/UTF-8/serendipity_lang_pt_PT.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/UTF-8/serendipity_lang_en.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/UTF-8/serendipity_lang_sa.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/UTF-8/serendipity_lang_cs.inc.php beschädigt oder verändert: Überprüfung fehlgeschlagenlang/UTF-8/serendipity_lang_se.inc.php beschädigt oder verändert:

Posted: Sat Dec 06, 2008 10:23 pm
by garvinhicking
Hi!

1. For upgrade problems, please simply delete the "checksums.inc.php" file.

2. Your comment problem might happen because of mod_security on your provider's webserver. please check back with him and ask him how that is configured. else you will need access to the server's error logs.

Regards,
Garvin

Posted: Sat Dec 06, 2008 11:03 pm
by Kilrathi
With the old version 1.3 the comments function is ok.

Posted: Sun Dec 07, 2008 2:14 am
by garvinhicking
Hi!

We would need the actual error that leads to the HTTP error. The HTTP error itself is quite unhelpful, so only the PHP(/Apache's) Errorlog (NOT Accesslog) would give a clue which kind of error is happening here.

Best regards,
Garvin

Posted: Sun Dec 07, 2008 12:57 pm
by Kilrathi
This must be the error from the log:

server ""path".de/php5-fcgi-starter" aborted: error parsing headers: duplicate header 'Status', referer: http://www.domain.net/index.php?/archives/file.html

Posted: Sun Dec 07, 2008 9:07 pm
by garvinhicking
Hi!

Which provider is this? I think this happens due to a line in index.php where we needed to use header('HTTP/1.0 200 OK') and header('Status: 200 OK') because on some PHP-CGI installations, the first header didn't work to reset a possible HTTP 400 error.

I would need some technical provider help to figure out how to really set this and why a double header has a fatal error...

Regards,
Garvin

Re: Comments Bug V 1.4 Beta1

Posted: Sun Sep 20, 2009 1:11 am
by nealk
Is there a fix for this yet?
I'm seeing this exact same problem.
Unfortunately, I'm using a remote hosting site (GoDaddy) and don't have access to the server logs.
I really don't want to downgrade back to 1.3...

Is there a known cause and workaround? Or better yet, a fix?

Re: Comments Bug V 1.4 Beta1

Posted: Sun Sep 20, 2009 2:51 am
by nealk
I've narrowed down the problem to one line:

functions.inc.php
function: serendipity_sendMail
The line is at the very end:
return mail($maildata['to'], $maildata['subject'], $maildata['message'], implode("\n", $maildata['headers']));

Since I don't have access to the web logs (I'm not the server admin), I'm debugging by putting a "return true;" before various lines.


if (!isset($maildata['skip_native'])) {
return true; // NAK: added
return mail($maildata['to'], $maildata['subject'], $maildata['message'], implode("\n", $maildata['headers']));
}

If I remove my debug return, then I get the 500 Server Error after submitting a comment.
Any idea why this is broken?

Re: Comments Bug V 1.4 Beta1

Posted: Sun Sep 20, 2009 2:58 am
by nealk
Nevermind -- found the problem.

"To:" is empty.

In the manage users, the user had no email address.

The workaround: give every blog user an email address.

The fix: check $maildata['to'] and only send email when it is not null.

Re: Comments Bug V 1.4 Beta1

Posted: Sun Sep 20, 2009 5:23 am
by Don Chambers
nealk - great job of finding the problem on your own! 8)

What do you think Garvin - worth a patch? I think so.

Re: Comments Bug V 1.4 Beta1

Posted: Mon Sep 21, 2009 10:12 am
by garvinhicking
HI!

Great detective skills, I couldn't have done that any better. I'ev committed a change to the s9y core so that mails will no longer be sent if "To" is empty.

Best regards,
Garvin