XHTL Validation errors for recaptcha plugin

Creating and modifying plugins.
Post Reply
sonichouse
Regular
Posts: 196
Joined: Sun May 11, 2008 2:53 am
Contact:

XHTL Validation errors for recaptcha plugin

Post by sonichouse »

The validator was failing my comment pages, so I made the following changes.

In serendipity_event_recaptcha/recaptcha/recaptchalib.php in function recaptcha_get_html

Code: Select all

<noscript>
		<iframe src="'. $server . '/noscript?k=' . $pubkey . $errorpart . '" height="300" width="500" frameborder="0"></iframe><br>
		<textarea name="recaptcha_challenge_field" rows="3" cols="40"></textarea>
		<input type="hidden" name="recaptcha_response_field" value="manual_challenge">
</noscript> ';
needs to be

Code: Select all

<noscript>
		<iframe src="'. $server . '/noscript?k=' . $pubkey . $errorpart . '" height="300" width="500" frameborder="0"></iframe><br />
		<textarea name="recaptcha_challenge_field" rows="3" cols="40"></textarea>
		<input type="hidden" name="recaptcha_response_field" value="manual_challenge"/>
</noscript> ';
In serendipity_event_recaptcha/serendipity_event_recaptcha.php:

Code: Select all

echo "\n<script>\n var RecaptchaOptions = { theme : '".$theme."', lang : '" . $serendipity['lang'] . "' };\n</script>";
we need to supply the script type

Code: Select all

echo "\n".'<script type="text/javascript">';
echo "\n var RecaptchaOptions = { theme : '".$theme."', lang : '" . $serendipity['lang'] . "' };\n</script>";
Steve is occasionally blogging here
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: XHTL Validation errors for recaptcha plugin

Post by garvinhicking »

Hi!

Thanks for that patch, committed.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Steve's on a roll lately!!! Keep up the great work!
=Don=
Post Reply