Serendipity Forums

Hi,

at first: I am not sure if this topic belongs to the themes-forum or plugins-forum as I have got a problem with the plugin emoticonchooser using the theme i3theme. But I guess it is an i3theme issue.

I've installed the latest version of serendipity, the emoticonchooser plugin and i3theme. The emoticonchooser is configured to provide a section with clickable smileys in the comment form.
But: When a smiley is clicked (and a link is called like "javascript:use_emoticon_comment(';-)')" it is not added into the comment-field.
Actually it works with other themes (the text ";-)" gets added to the comment-field).
I have tried to compare the i3theme comment-templates with templates of other themes but unfortunately I am not really good at templating.

Is this "clickable smileys"-problem already known?
Maybe you could give me a hint at how to fix this

Thanks in advance and kind regards

Carnivore wrote:I am not sure if this topic belongs to the themes-forum or plugins-forum

Since it seems to only appear with the i3theme, it is clearly a theme-related issue

Carnivore wrote:But: When a smiley is clicked (and a link is called like "javascript:use_emoticon_comment(';-)')" it is not added into the comment-field.

Unfortunately, I really don't have the time to even look at it now. May take until Monday or Tuesday. If someone else can offer a solution in the meantime, go right ahead.

Sorry for the delay, but I'm swamped right now

YL

I managed to have a look at this today, and the problem is in commentform.tpl, the plugin is looking for serendipity_commentform_comment to insert the emoticon, but it is has an id of comment.

The fix I think is This seems to work for me, but it would be worth someone else double checking.

The same fix needs to be applied to the plugin_contactform.tpl as well.

sonichouse wrote:The fix I think is

Code: Select all

<textarea rows="10" cols="100%" id="serendipity_commentform_comment" name="serendipity[comment]" tabindex="4">{$commentform_data}</textarea>

Perfect. I just now committed the fix to spartacus. Thanks for helping out here, I really appreciate it. Back to the saltmines.

YL

yellowled wrote:Perfect. I just now committed the fix to spartacus. Thanks for helping out here, I really appreciate it. Back to the saltmines.

No problem, don't stay down there for too long, you will be missed .

Hi,

I just came back from a work-weekend

The "clickable smileys" are really working fine now! Thanks you so much!!

Furthermore I am really impressed by your quick support!
I will love to use serendipity and maybe I can help at other issues (when it's not templating )

Thanks to you!

Carnivore wrote:Furthermore I am really impressed by your quick support!

That's not quick. You should see Garvin, he's way faster than us mere mortals

Carnivore wrote:I will love to use serendipity and maybe I can help at other issues (when it's not templating )

The "usually suspect" areas then would be writing documentation or helping with translations. Any help is greatly appreciated.

YL