Page 1 of 1
Bug in History plugin?
Posted: Mon Apr 14, 2008 2:08 pm
by yellowled
While working on its HTML output, I played around with the History plugin a lot, but I never got it to actually display the entry body. The relevant part of the plugin code as far as I understand it is:
Code: Select all
strip_tags($e[$x]['body']) . '<br />';
Is this a bug in the plugin or a misconfiguration in my devblog?
YL
Re: Bug in History plugin?
Posted: Mon Apr 14, 2008 3:12 pm
by garvinhicking
Hi!
Body is only shown when this is enabled in the config of the history plugin. (something like "Fetch full"...)
REgards,
Garvin
Re: Bug in History plugin?
Posted: Mon Apr 14, 2008 5:43 pm
by yellowled
garvinhicking wrote:Body is only shown when this is enabled in the config of the history plugin. (something like "Fetch full"...)
Erm ... yeah, I know. Exactly my point. I
did turn it on in the plugin config explicitly, yet it still doesn't show up in the sidebar ...
YL
Re: Bug in History plugin?
Posted: Tue Apr 15, 2008 11:58 am
by garvinhicking
Hi!
I just committed a fix , can you try that?
REgards,
Garvin
Re: Bug in History plugin?
Posted: Tue Apr 15, 2008 12:16 pm
by yellowled
garvinhicking wrote:I just committed a fix , can you try that?
I know, I was just about to commit my changes to that plugin to svn when I noticed the update
Yup, now it's working. I'll commit my changes to the code now.
YL
Re: Bug in History plugin?
Posted: Tue Apr 15, 2008 12:48 pm
by yellowled
yellowled wrote:I'll commit my changes to the code now.
Hmmm. Once I put this:
Code: Select all
strip_tags($e[$x]['body']) . '<br />';
into a div like this
Code: Select all
echo '<div class="serendipity_history_info"><span class="serendipity_history_author">' . $author . '</span> <span class="serendipity_history_date">'. $date . "</span> <a href='$url' title='".str_replace("'", '`', htmlspecialchars($e[$x]['title']))."'>". htmlspecialchars($t) . '</a></div><div class="serendipity_history_body"' .
strip_tags($e[$x]['body']) . '</div>';
the body disappears
again. Any idea why this is? It would really be nicer to put the body into a div, too.
YL
Re: Bug in History plugin?
Posted: Tue Apr 15, 2008 12:58 pm
by yellowled
yellowled wrote:Any idea why this is?
Because I am too stupid, that's why
Problem solved.
YL