Page 1 of 1
Bulletproof | change search after update s9y 1.3?
Posted: Fri Mar 21, 2008 2:29 pm
by u1amo01
It looks like after updating to s9y 1.3 there happened something strange with the search field in bulletproof. To start search you have to click now on a button with the sign ">".
How can I change the ">" into text?
(because I use search in my own blog not very often I'm not sure if this is really connected with the update to s9y 1.3)
http://blog.u1amo01.de
Posted: Fri Mar 21, 2008 2:54 pm
by Don Chambers
That is not part of the bulletproof template... that is in the s9y quicksearch code. We did not add it to the bulletproof template, but we probably should. The button was added for accessibility reasons (I think).
It also appears it was hard coded as a "greater than" sigh (>) not a language constant, so if you really want something different, you would need to modify it in the /include/plugin_internal.inc.php file on line #385 (version 1.3):
Code: Select all
<input class="quicksearch_submit" type="submit" value=">"
, but that revision would be overwritten with any future upgrade to s9y.
Posted: Fri Mar 21, 2008 3:13 pm
by u1amo01
Hmm, I find the ">" sign for search confusing.
Changed it to a text. And it's also necessary to change
to something bigger like 8em, as I did.
Thank you very much
Posted: Fri Mar 21, 2008 10:12 pm
by yellowled
Don Chambers wrote:The button was added for accessibility reasons (I think).
You're right.
Don Chambers wrote:It also appears it was hard coded as a "greater than" sigh (>) not a language constant
That was Garvin's call, as far as I remember. And I'm sure your "sigh" is some kind of Freud thing
Yes, we should cover that for BP. Gives us a good reason for a new release.
BTW, another nice fix would be to simply hide the submit button using CSS:
Code: Select all
input.quicksearch_submit { display: none; }
I suggest to use user.css for this (see the appropriate theme option in BP).
YL
Posted: Fri Mar 21, 2008 10:14 pm
by yellowled
u1amo01 wrote:Hmm, I find the ">" sign for search confusing.
That, as well as the 2em width, is a backwards compatibility thing, if I remember correctly. Remember: This is a plugin, not a template. It is used with a variety of different templates, so there could be cases where a wider button with text on it could look bad or even break layouts.
YL
Posted: Sat Mar 22, 2008 8:57 am
by u1amo01
BTW, another nice fix would be to simply hide the submit button using CSS:
If you hide this button the user has to press enter to get his search done. Not good, I think. Can't remember how it was before; maybe just a click on the lens sign?
I'll install somewhere the older version and will have a look later.
Posted: Sat Mar 22, 2008 10:17 am
by u1amo01
Ahem, ok, in the older version you had to press Enter to search.
So I think I'll use the hide solution with CSS until I've got Garvins book and learned how to make it better