Page 1 of 1

Event plugin duplicate installation

Posted: Fri Mar 11, 2005 10:35 pm
by petree2
When you install a new sidebar plugin, it puts you back on the configure plugins page. But, the url for this page is actually the link to add the plugin.

Example:
/serendipity_admin.php?serendipity[adminModule]=plugins&serendipity[pluginPath]=serendipity_event_templatechooser&serendipity[install_plugin]=serendipity_event_templatechooser

Instead of:

/serendipity_admin.php?serendipity[adminModule]=plugins

If you refresh on the former, it will install the plugin a second time (not intended for event plugins I don't think). I did this by accident and sucessfully installed the trackback plugin twice. Oops.

Re: Event plugin duplicate installation

Posted: Sun Mar 13, 2005 1:30 pm
by garvinhicking
Well, we have lots of places where using the "REFRESH" button would create double actions. Users should always be aware of this? :)

We need that URL redirection because some plugins offer a configuration screen after being installed - and that can only be detected after the plugin has been inserted and not before. Well, it could be detected earlier, but that would require quite a bit of code introspection and IMHO does not "pay off".

I'll see if we can implement a second redirection after a plugin has been inserted without config options...

Regards,
Garvin

Re: Event plugin duplicate installation

Posted: Sun Mar 13, 2005 2:31 pm
by garvinhicking
Okay, I've just patched the second redirection into the plugin. :)

Regards,
Garvin

Posted: Sun Mar 13, 2005 6:14 pm
by petree2
excellent.