Page 1 of 1

go-button on quicksearch?

Posted: Fri Nov 23, 2007 3:45 pm
by stm999999999
After updating my installations I get a ">" / "go!"-Button behind my search field - is there any way to delete this?

Re: go-button on quicksearch?

Posted: Fri Nov 23, 2007 3:56 pm
by garvinhicking
Hi!

Hm, at least not with CSS 2 :)

I just updated SVN and gave that go-button a class name with which you can specifically address it with CSS.

The button was added because of accessibility reasons.

Regards,
Garvin

Re: go-button on quicksearch?

Posted: Fri Nov 23, 2007 9:54 pm
by Don Chambers
garvinhicking wrote:Hi!
The button was added because of accessibility reasons.

Regards,
Garvin
Is this addition just for 1.3? I don't see it updated in 1.2 branch.....

What is the issue with accessibility? If this is an issue, it would be nice to see in 1.2 so we can address the same thing for bp.

Re: go-button on quicksearch?

Posted: Sat Nov 24, 2007 12:46 am
by garvinhicking
Hi!

Yeah,thisis 1.3 only.
What is the issue with accessibility? If this is an issue, it would be nice to see in 1.2 so we can address the same thing for bp.
I didn't backport it to 1.3 because of the BC-impactit has. IMHO it's not worth backporting to 1.2...

regards,
Garvin

Re: go-button on quicksearch?

Posted: Sat Nov 24, 2007 1:10 am
by stm999999999
garvinhicking wrote: I just updated SVN and gave that go-button a class name with which you can specifically address it with CSS.
something like display: none, right?

Re: go-button on quicksearch?

Posted: Sat Nov 24, 2007 2:58 am
by Don Chambers
stm999999999 wrote:something like display: none, right?
Seems right to me! :lol:

@ Garvin - what is the specific accessibility issue to using a button, and why is this such a problem to backport to 1.2? I really do not want to start a 1.3bp branch right now... but since we do have an option to display a quicksearch field in the bp navbar, I think we need to give this some thought.

Re: go-button on quicksearch?

Posted: Sat Nov 24, 2007 3:46 pm
by garvinhicking
Hi!
@ Garvin - what is the specific accessibility issue to using a button, and why is this such a problem to backport to 1.2? I really do not want to start a 1.3bp branch right now... but since we do have an option to display a quicksearch field in the bp navbar, I think we need to give this some thought.
It's simply that HTML forms without a submit button are thought to be not accessible, because a screenreader cannot "push" an input text button.

I dislike the backporting because somewhere we have to draw a line between 1.2 and 1.3, backporting is always hard because it increases the overhead for maintaining...

Regards,
Garvin