Page 1 of 1
FreeTag options not always applied, other bugs
Posted: Tue Sep 04, 2007 12:20 pm
by drx
Hi, i found that the freetag-pluigin's options do not affect all appearances of the tags.
I can select maximum and minimum sizes, but they only work in the tag cloud that appears when a tag is clicked. The "sidebar" part only has default sizes (100%-300%). However, i can chose a sorting method here, this does not apply to the "tag cloud" that appears when tag filtering is happening. I think this is unlogical.
Also, in the tag cloud, there is always an empty h2 heading generated:
Code: Select all
<h2 class="serendipity_date"></h2>
Plus, in the tag cloud, the currently selected tag is not displayed, only the ones connected to it. It would be a great improvement if the text in
Code: Select all
<div class="serendipity_freetag_taglist_related">
wouldn't only say "Related Tags" but include the actual tag these tags are related to.
Maybe the plugin could put all this into smarty templates so i wouldn't have to complain all the time about some details only i care about

That would be highly appreciated.
Best greetings,
drx
Re: FreeTag options not always applied, other bugs
Posted: Tue Sep 04, 2007 2:53 pm
by garvinhicking
Hi!
drx wrote:Hi, i found that the freetag-pluigin's options do not affect all appearances of the tags.
Yes, currently the tag cloud and the sidebar plugins are two different "views" and they work a bit distinct from each other.
Code: Select all
I can select maximum and minimum sizes, but they only work in the tag cloud that appears when a tag is clicked. The "sidebar" part only has default sizes (100%-300%). [/quote]
Grischa just yesterday committed a patch to be able to set the font size for the tag cloud as well.
The reasoning behind only having it for the sidebar is that you AFAIR use custom theme CSS to format the tag cloud, and that a sidebar usually has much less space than the tag cloud.
[quote]However, i can chose a sorting method here, this does not apply to the "tag cloud" that appears when tag filtering is happening. I think this is unlogical.[/quote]
The sorting method was invented because a user wanted it for the sidebar. He didn't request that for the tag cloud, which is the reason why it's not yet implemented. It just need to be copied as well.
[quote]
Also, in the tag cloud, there is always an empty h2 heading generated:
[/quote]
In the PHP code, inside the serendipity_date I see that there's a
[code]
$tagTitle = is_array($this->displayTag) ? implode(' + ',$this->displayTag) : $this->displayTag;
printf ($title, $tagTitle);
But $title is not defined, so I wonder what should be there. Maybe
would already be the proper display?
Maybe the plugin could put all this into smarty templates so i wouldn't have to complain all the time about some details only i care about

That would be highly appreciated.
I second this, if someone made smarty templates for this.
Best regards,
Garvin
Posted: Thu Sep 06, 2007 3:04 pm
by drx
Thanks, now the tags work much better!!
What is left is that
<h2 class="serendipity_date">
is used to display the current tag ... this is not a date
Anyway, great, i used the spartacus update for the first time.
Almost no issues, except that i used the back button after the install several times and then had to delete 3 instances of the plugin. It was not a problem tho.
Best greetings,
drx
Posted: Thu Sep 06, 2007 3:06 pm
by garvinhicking
Hi!
is used to display the current tag ... this is not a date
Not really. But most templates use a "h2.serendipity_date" for the markup that requires the current tag title, so we can't easily change that, until the plugin gets smarty syntax.
Best regards,
Garvin
smarty
Posted: Wed Nov 07, 2007 9:13 pm
by drx
Hey guys, how is it going with smartyfying the freetag plugin?
Re: smarty
Posted: Thu Nov 08, 2007 10:57 am
by garvinhicking
Hi!
drx wrote:Hey guys, how is it going with smartyfying the freetag plugin?
I don't know, did anyone already volunteer for that?
Regards,
Garvin
Tag News?
Posted: Wed May 07, 2008 4:42 pm
by drx
Hi, it's me again, your constant tagging-nagger ;)
I would actually try to include smarty templates into the tag plugin. Is there some sort of documentation how to use templates in a plugin? All the plugins i have installed don't seem to sport any templates. If you could tell me a plugin that does i might be able to figure it out from the example.
Another thing: I read the source of serendipity_event_freetag.php and found there a todo-list.
* - - Super-Tag (tags 'php', 'java' and 'scheme' are super-tagged to tag code)
Just wanted to say that you do not need that. As soon as it is possible to combine several tags together, a hierarchy is build automatically. For example you tag a post with 'php' and 'code', as soon as you select 'code', the 'php' ones will show up as well. The whole point of tagging is to remove stable hierarchies and enable hierarchy-on-demand.
About most of the other todo-things i can't say a lot. :)
Best greetings,
drx
Re: Tag News?
Posted: Thu May 08, 2008 9:42 am
by garvinhicking
Hi!
Here's a list of some plugins that support templateS:
*serendipity_event_staticpage
*serendipity_event_Contactform
*serendipity_event_faq
HTH,
Garvin