Bulletproof: Commenters E-Mail

Skinning and designing Serendipity (CSS, HTML, Smarty)
Post Reply
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Bulletproof: Commenters E-Mail

Post by blog.brockha.us »

Wow! I noticed, that the template is publishing the email of commentors! I think, this should be at least configurable! I don't want my commentors to be spammed.. :shock:

Okay, the email is obfuscated a littel, but I think, it wont lock out real spammers..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Bulletproof: Commenters E-Mail

Post by yellowled »

blog.brockha.us wrote:Wow! I noticed, that the template is publishing the email of commentors! I think, this should be at least configurable! I don't want my commentors to be spammed.. :shock:

Okay, the email is obfuscated a littel, but I think, it wont lock out real spammers..
Hmmmm. I have to admit I have no idea what the source for this might be ... commentform.tpl basically has the same functions like default/commentform.tpl ... also, I don't think this is responsible for displaying the email address. Or is it? Garvin?

YL
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Comment author emails are handled exactly the same way in BP as they are in s9y by default. FYI - it is in the comment.tpl file, and we could easily add an option in there to suppress it entirely.
=Don=
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

Don Chambers wrote:Comment author emails are handled exactly the same way in BP as they are in s9y by default. FYI - it is in the comment.tpl file, and we could easily add an option in there to suppress it entirely.
... which we don't need since there's a s9y option to do that already if I remember correctly. But what does this mean if Grischa experienced it anyway? Some kind of bug in a plugin?

YL
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

The comment.tpl in the BP theme explicitly adds the commentors email, if found. I disabled the line with a "if (false and CommentorHasEmail)", now it is gone.

What s9y Option do you meen, yellowed? I think the only option s9y gives is to obfuscate it but not to supress it at all..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

The spamblock plugin and the s9y configuration should have a global option to "show commentors email addresses".

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Email addresses are not required for comment posting by default (but can be required via the spamblock plugin). If one is provided, s9y shows that as address[at]domain.com. I think that is quite reasonable. Not every single comment poster wants to necessarily have their email address completely unavailable on a particular blog. Most of us have email accounts we use in this manner that we EXPECT to get spammed, so we set up every possible firewall, spam preventer, etc on that account. So, I personally like the way it is handled by default.

That being said, I know of no way that totally supresses the comment author's obscured email address. That MIGHT be the way the option is intended to work in the spam protector plugin, but I just tried it and it made no difference at all. Perhaps I am doing something wrong?
=Don=
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

Well, it is easy to supress it changing the comment.tpl of course. And this could be configurable with a new entry in the bp templates configuration..

@Garvin: The SpamBlock plugin has this option, but using the BP theme the E-Mail is displayed even with switched off E-Mail displaying (but obfuscated). Maybe there is a bug in the SpamBlock plugin? Hmm.. I have to look into the code..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi Grischa!

Could it be that you'Re just seeing it because you're logged in? For logged in users, emails are not obfuscated/removed.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

Rrrright! :-) That was the problem. Thanks Garvin!
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Post by yellowled »

blog.brockha.us wrote:Well, it is easy to supress it changing the comment.tpl of course. And this could be configurable with a new entry in the bp templates configuration..
I'm slightly concerned we might overload those. There are a lot of them already, so my personal opinion is to not add anything unless it's really worthwhile. I'm not sure whether this one is, though.

YL
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Post by blog.brockha.us »

It isn't as it can be done with the AntiSpam plugin already, as Garvin told me/us.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Garvin nailed it - we are all looking at this as admins!!! Done issue closed, IMHO.
=Don=
Post Reply