Page 1 of 1

serendipity_plugin_linklist - css outpout

Posted: Sat Jul 28, 2007 12:15 am
by stm999999999
hello,

serendipity_plugin_linklist makes an output to the css-file, even if there are hand-made css-definitions for the linklist-elements.

So, it is not possible to make own css-definitions, because after them the plugin-made definitions are given to the css-file and they override the previous hand-made ones. :-(

Other plugins with css-definitions check whether there are already hand-made definitions.

Re: serendipity_plugin_linklist - css outpout

Posted: Sat Jul 28, 2007 1:48 pm
by garvinhicking
Hi!

Until this gets fixed, you could use !important styles, or maybe directly edit the linklist.css file (this comes out of the CSS file not the PHP plugin.

After my holidays I might have a closer look, or someone else does before.

Regards,
Garvin

Posted: Tue Jul 31, 2007 5:57 pm
by mgroeninger
Hi Stephan!

I think you are talking about the same bug you reported in http://board.s9y.org/viewtopic.php?t=10617

I just added a block to check for that and bumped the version to 1.96

Can you make sure it works for what you were doing? I did a brief test on my server and it seemed to be working.

Posted: Tue Jul 31, 2007 9:06 pm
by stm999999999
yes, this is the same - I forgot to write a notice to here.

1) Did you use my suggested code or another one?

2) Did you apply the other patch as well?

And I will test it as soon as I get it via Spartacus.

Posted: Wed Aug 01, 2007 12:14 am
by mgroeninger
1) Did you use my suggested code or another one?
Basically it was your patch... I just changed it so that there is only uses one stristr test... (no real reason for the change, I just thought this looked a bit cleaner) You can see the change here: http://php-blog.cvs.sourceforge.net/php ... 35&r2=1.36
2) Did you apply the other patch as well?
Um, which other patch? Sorry, but I have probably missed another issue on the forums somewhere... Or was I sitting on a patch we had discussed?

Posted: Wed Aug 01, 2007 12:23 am
by stm999999999
I have a look at it - at first view it seems to me to be good code ;-)
Um, which other patch? Sorry, but I have probably missed another issue on the forums somewhere... Or was I sitting on a patch we had discussed?
the on for entrypaging on http://board.s9y.org/viewtopic.php?t=10617

Posted: Wed Aug 01, 2007 12:39 am
by mgroeninger
stm999999999 wrote:the on for entrypaging on http://board.s9y.org/viewtopic.php?t=10617
Ahh.. no I hadn't done that patch. :D Generally I skip over things that have to do with plugins I haven't worked on before.

That one was simple enough I patched it though, after you pointed it out to me. Sorry I wasn't paying attention to the rest of the post.

I did a version bump, as well.

Let me know if you have any problems...

Posted: Wed Aug 01, 2007 1:18 am
by stm999999999
Thanks!

It is all about the fact that I have no sourceforge-Account (to the s9y-project) and more important I think I have no tools do apply patches to sf.