Coding Standards
Posted: Sun Jul 15, 2007 10:54 pm
this is new, in't it?documentation_XX.html file.
hm, if I have a look at http://spartacus.s9y.org/index.php?mode ... s_event_en most (all?) plugins are GPL.By default, a s9y plugin is BSD licensed.
We have already code that works only with Mysql - this code is even in the s9y-core (image movingOnly use SQL statements that work in PostgreSQL, SQLite and MySQL.
I specifically haven't put license files in my plugins because I wanted them to be BSD (or even less restrictive).hm, if I have a look at http://spartacus.s9y.org/index.php?mode ... s_event_en most (all?) plugins are GPL.
Code: Select all
$propbag->add('copyright', 'Plugin: BSD. Bundled libraries contain GPL code.');Yes!this is new, in't it?documentation_XX.html file.
You're right. The spartacus plugin defines plugins with empty licensing as GPL. I've changed that to read "N/A (=GPL)" in the future.hm, if I have a look at http://spartacus.s9y.org/index.php?mode ... s_event_en most (all?) plugins are GPL.
Yes, but I mentioned that the code should fork if functionality only works in one of the database systems. Plugins should not FAIL if they are executed on foreign DBs, because some functionality does not exist in others, and it should still be usable if the plugin likes to.We have already code that works only with Mysql - this code is even in the s9y-core (image movingOnly use SQL statements that work in PostgreSQL, SQLite and MySQL.)
No, I really want to force plugin developers to use generic SQL. Lazy developers would otherwise use MySQL syntax where not really required.I think we should not have sql-indipendant as a must but should - it has to be a must to declare such dependicies! And to have a if mysql-cause in the code
I haven't used a propbag anywhere there is a conflict, so nothing needs to change. It might make sense to add a propbag in places, but I have been very careful not to relicense code. (In fact, a quick glance looks like none of the the additional plugins uses the "copyright" propbag setting.)garvinhicking wrote: Matt: Please change the 'license' propbag in that case for the plugins you've worked on?
I believe that is easier, but I think the clearly labeling licensed components would allow us to split license by file or directory. But if you believe this is untenable to support and don't want to do this with the plugins, I'll abide by that (how ever much it hurts to see my code go GPL).If external GPL libraries are BUNDLED, then you CANNOT make the Plugin 'BSD' code.
yes, there can be plugins or functions of plugins which need mysql.Ruhe wrote:This could mean that I possibly can't use a plugin only because I'm using a database other than MySQL?
No.A plugin should work with and on every database.
Code: Select all
if mysql do it the easy way else do it the hard wayÄh, OK, perhaps my english is not good enough: What do you mean?mgroeninger wrote: Updated- I've used Stephan's name enough I shouldn't be forgetting it... Sorry about that Stephan!
*laugh* your english is fine... I originally just used your account name (stm999999999) to refer to you... when I re-read it I decided I really should call you by your real name, since I know what it is and all.stm999999999 wrote:Äh, OK, perhaps my english is not good enough: What do you mean?
Thanks!*laugh* your english is fine...
or name me stm9x9 like GarvinI originally just used your account name (stm999999999) to refer to you... when I re-read it I decided I really should call you by your real name, since I know what it is and all.
never mindSorry about the confusion.