Page 1 of 1
Recursive comment references possible
Posted: Mon Jun 11, 2007 7:36 pm
by urs.enke
When editing a comment, it is possible to make it the child of one of its own offspring. It's stupid to do, but the involved comments then disappear until parenthood is set again.
Re: Recursive comment references possible
Posted: Tue Jun 12, 2007 12:57 pm
by garvinhicking
Hi!
Good catch! Fixed in SVN.
Best regards,
Garvin
Re: Recursive comment references possible
Posted: Tue Jun 12, 2007 2:11 pm
by urs.enke
It is now impossible to make an entry a child of itself, but one can still make it a child of a child, grandchild etc. With the current database structure, there will have to be a non-trivial query to determine all offspring. Alternatively, when the list of possible parents is created for the edit dialog, the branch could be cut that starts with the article being edited.
Re: Recursive comment references possible
Posted: Tue Jun 12, 2007 2:39 pm
by garvinhicking
Hi!
I agree, that is still possible. But that lies in the responsibility of an Admin to NOT edit an entry to do that.
In some cases it is wanted that you can change complete tree structures, so I don't think we should remove the option that people can freely attach structures.
Regards,
Garvin
Re: Recursive comment references possible
Posted: Tue Jun 12, 2007 3:02 pm
by urs.enke
In some cases it is wanted that you can change complete tree structures, so I don't think we should remove the option that people can freely attach structures.
Surely, I was only talking about cutting that branch of the tree that starts with the article being edited. This would leave all (sensible) options to the user.