Timbalu wrote:Adding an option to the serendipity_emit_htmlarea_code() function, to also check for a custom config file in custom template, is nothing bad to have, if we say "use at your own risk"!
Else, anybody is able to just easy replace the shipped standard htmlarea/ckeditor package with an extended or less functional "mini" package, without needing to change anything else.
Now that my solution has been proofed some days, we could discuss this:
I thought of giving up /htmlarea directory at all and move the ckeditor lib into /bundled-libs/js/, since it is a bundled lib after all.
First I thought this was a great idea, but now I got some doubts about it. Making an easy custom config js file available in a custom template would need us to check for serendipity_getFile(), which is kind of bad to do, since it needs to be called in the custom plugin js file. So moving to bundled-libs
and giving access to a custom config via templates, would need some changes making a simple and lightweighted approach for the most of us a little more difficult.
I personally tend to leave it as is, in /htmlarea, which is easy accessible and reachable (*), and suggest any of those users Garvin had in mind to change /htmlarea content in case of any custom enhancements. (
I know this would need them to do this after each Serendipity release upgrade, but I think for this few, this wouldn' be that bad, since just a copy and paste/upload issue.)
Any thoughts?
(*)
btw, does htmlarea now need any changes in permissions?