comment notifications died

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

I don't see why that mail is so mangled, that worked on my setup.

Let's try this first: If you know copy the link from between the =0A=0A and remove the = at the linebreaks, visit it in your browser, the account should be activated then.
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

I don't see a new user here:

Code: Select all

https://imperfectchristians.net/serendipity_admin.php?serendipity[adminModule]=users
And, I didn't receive a message at qrv@kd4e.com

But I did receive another email at: admin@imperfectchristians.net
new-user-captcha-off-confirm-email2.jpg
new-user-captcha-off-confirm-email2.jpg (91.77 KiB) Viewed 18976 times
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

Hm, after going through the complete flow the user should appear. I confirmed that the plugin is not too broken for that at least.

After you copied the link the user should get an email like this:
An author account has just been created for tester (test@example.com) on the blog https://.../s9y_dev/serendipity_admin.php. To activate this account, click here:

https://.../s9y_dev/index.php?serendipity%5Badduser_activation%5D=7f006ecffb52f22b00cd38bc849e3b8b#adduser

After you have clicked there, logging in is possible with the submitted password. This E-Mail has been sent to the owner of the blog as well as the new author.
I got it at both email accounts, user and admin. After clicking on that link the user appeared.

But maybe this is connected to the mangled email, that your from says "text/plain, quoted-printable" is very strange. I'm very surprised the mail even got delivered like that, if the headers are that broken. I will have a second look at the code, but please continue to experiment with this at well. Maybe it is connected to some setting, the email client or finally really a server issue.
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

My email accounts are all hosted at bluehost.com

They're associated with domains that I have hosted there.

This is what it looks like in RoundCube on Bluehost.com
[Imperfect Christians] [Imperfect Christians] [Approval required] A new author account has been created
From "Imperfect Christians" <admin@imperfectchristians.net> Reply-To: "Imperfect Christians" <qrv@kd4e.com> X-Mailer: Serendipity/2.5.0 X-Engine: PHP/8.2.18 Message-ID: <ab973cbd45835bd6d88bd3c85304a304@imperfectchristians.net> MIME-Version: 1.0 Precedence: bulk Content-Type: text/plain, charset=UTF-8 Auto-Submitted: auto-generated Content-Transfer-Encoding: quoted-printable
To admin@imperfectchristians.net
Date Today 15:03
Contact photo
Message Body
An author account has just been created for newusertest1 (qrv@kd4e.com) on =
the blog https://imperfectchristians.net/serendipity_admin.php. To allow th=
e user to activate his account, click here:=0A=0Ahttps://imperfectchristian=
s.net/index.php?r=3D1&serendipity%5Badduser_activation%5D=3De826ecb7f599745=
7bf7223b26cb03719#adduser=0A=0AAfter you have clicked there, the author wil=
l receive an email allowing him to login with his password.=0A=0A-- =0AImpe=
rfect Christians is powered by Serendipity.=0AThe best blog around, you can=
use it too.=0ACheck out <https://s9y.org> to find out how.
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

Just saw this when I logged back in with Admin "Chief Editor" privileges.
new-user-comment-approve-1.jpg
new-user-comment-approve-1.jpg (41.99 KiB) Viewed 18962 times
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

This just arrived ...

[Imperfect Christians] [Requires review] A new trackback has been made to your blog-entry entitled "What God Did & Why - (Week 2 of 2) Small Group - Word Study".
=0A=0ARequires review: Yes (IP= validation: startahomecarebusinessinmichigan.net [66.198.240.25] !=3D send=er ip [5.157.20.112, ua=3D"PHP/5.2.58"])=0ALink to entry: https://imperfect=christians.net/index.php?/archives/4-What-God-Did-Why-Week-2-of-2-Small-Gro=up-Word-Study.html=0AWeblog: how to start home care business Michigan=0ALin=
k to remote-entry: https://startahomecarebusinessinmichigan.net=0A=0AExcerp=
t:=0AWhat God Did & Why - (Week 2 of 2) Small Group - Word Study | Imperfec=
t Christians=0A=0A----=0AYou have the following options available:=0A Warn=
ing: This trackback needs approval before it will be displayed=0A View en=
try -- https://imperfectchristians.net/index.p ... What-God-=
Did-Why-Week-2-of-2-Small-Group-Word-Study.html=0A Delete trackback -- ht=
tps://imperfectchristians.net/index.php?/delete/trackback/3/4-What-God-Did-=
Why-Week-2-of-2-Small-Group-Word-Study.html=0A Approve trackback -- https=
://imperfectchristians.net/index.php?/approve/trackback/3/4-What-God-Did-Wh=
y-Week-2-of-2-Small-Group-Word-Study.html=0A=0A-- =0AImperfect Christians i=
s powered by Serendipity.=0AThe best blog around, you can use it too.=0AChe=
ck out <https://s9y.org> to find out how.
A new trackback has been made to your blog-entry entitled "What God Did & W=
hy - (Week 2 of 2) Small Group - Word Study".=0A=0ARequires review: Yes (IP=
validation: startahomecarebusinessinmichigan.net [66.198.240.25] !=3D send=
er ip [5.157.20.112, ua=3D"PHP/5.2.58"])=0ALink to entry: https://imperfect=
christians.net/index.php?/archives/4-What-God-Did-Why-Week-2-of-2-Small-Gro=
up-Word-Study.html=0AWeblog: how to start home care business Michigan=0ALin=
k to remote-entry: https://startahomecarebusinessinmichigan.net=0A=0AExcerp=
t:=0AWhat God Did & Why - (Week 2 of 2) Small Group - Word Study | Imperfec=
t Christians=0A=0A----=0AYou have the following options available:=0A Warn=
ing: This trackback needs approval before it will be displayed=0A View en=
try -- https://imperfectchristians.net/index.p ... What-God-=
Did-Why-Week-2-of-2-Small-Group-Word-Study.html=0A Delete trackback -- ht=
tps://imperfectchristians.net/index.php?/delete/trackback/3/4-What-God-Did-=
Why-Week-2-of-2-Small-Group-Word-Study.html=0A Approve trackback -- https=
://imperfectchristians.net/index.php?/approve/trackback/3/4-What-God-Did-Wh=
y-Week-2-of-2-Small-Group-Word-Study.html=0A=0A-- =0AImperfect Christians i=
s powered by Serendipity.=0AThe best blog around, you can use it too.=0AChe=
ck out <https://s9y.org> to find out how.
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

Good. This tells us that the error does not lie with the plugin, but is a general incompatibility between s9y and that environment.

In the current development version, the first change was related to this:
Make serendipity_sendMail() standard compliant by using CRLF instead of LF to separate headers.
This is one small change from https://github.com/s9y/Serendipity/comm ... 3eae617005. Easiest way to test it: Replace your include/functions.inc.php with https://raw.githubusercontent.com/s9y/S ... ns.inc.php.

I bet this will fix the email display, and since the adduser plugin works for me it will then be easier to get it to work for you as well - and in any case, you need better rendered emails for your users anyway.
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

I'm guessing that this is in one of the subfolders, within /plugins, but I'm not finding a include/functions.inc.php in the adduser or comments folders.

When should I be looking, instead, please?

Thanks.
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

Not in plugins/, include/ is on the main level of your blog. It's part of the core of serendipity, not part of the plugin :)
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

This is what I see ...
functions-php-1.jpg
functions-php-1.jpg (86.91 KiB) Viewed 18912 times
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

Did you miss it in the list? It is the second file after the three directories :)
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

onli wrote: Sun May 25, 2025 9:38 pm Did you miss it in the list? It is the second file after the three directories :)
It was pre-coffee ... "And that's my story and I'm sticking to it!" :-)
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

OK, so I cut and pasted the contents here:
https://raw.githubusercontent.com/s9y/S ... ns.inc.php

... in place of what was there, and saved it.

Do I need to restart anything or will the changed code be used when a New User subscription is attempted?
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: comment notifications died

Post by onli »

The code will be used immediately. So all future emails have the new linebreaks, which might help in displaying them properly. I would now try the registration again.
DavidC
Regular
Posts: 75
Joined: Wed May 14, 2025 7:16 pm

Re: comment notifications died

Post by DavidC »

Just received this ...
new-user-email-inbox1.jpg
new-user-email-inbox1.jpg (186.31 KiB) Viewed 18901 times
Post Reply