Commentedit: Edit comments some time after posting them

Creating and modifying plugins.
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

Fantastic, now it's running with lightbox activated. I used ligntbox 2, but now I've chosen lightbox plus.

Learning is a good effect, so we both profit by that ;) You learned more about js, I got a usefull plugin :D

Thanks for your good job and this great plugin.
Keep it Country,
Markus
Cowboy of Bottrop
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

I'm not totally happy with how it treats the original markup, maybe I'll work on that later. Please give me feedback if anything don't work well, until that I'm very happy it works for you :)
sincerely
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

One thing would be nice, but its not important:
Is it possible to filter out the html for the avatar in the text box? This html is not stored to the db until the comment is edited. After editing I find the html in the comment when I take a look into the db.
Keep it Country,
Markus
Cowboy of Bottrop
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

That's a part of the markup-issue. Commentedit works directly upon the already parsed html, which leads to such issues. I'll try to change that, but until now I think it's not easy.
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

What's about reading the text box content from the db? That effects, that probably used bb-code is displayed again and can be edited too.
Keep it Country,
Markus
Cowboy of Bottrop
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

Yes, that's exactly the way to go. I'll see if I find the time this evening, it's time I don't really have ;)
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

Easier than I thought. Attached version fetches the comment from the db, which should preserve all markup and solve the gravatar-issue.

By the way: I oversaw that the untested mail-notification was activated in the last version. Did it work? Added a config-option in that version and disabled it by default.
sincerely
Attachments
serendipity_event_commentedit-0.2.tar.gz
(11.62 KiB) Downloaded 375 times
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

Mail-notification? You mean, I should get a mail when someone's edited his comment?
Guess it didn't work. I edited one comment myself, if others did I don't know. There were no mails about that.

I will test the new version of the plugin tomorrow, now it's time to go to bed ;)
Keep it Country,
Markus
Cowboy of Bottrop
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

To nervous, so I hat to test it right now ;)
The html code for the gravatar is still shown in the text box, but the mail-notification is working fine now.
Keep it Country,
Markus
Cowboy of Bottrop
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

The comment is fetched from the database, the gravatar-code really shouldn't appear... You really got an mail?
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

I just tried again, and the html wasn't shown in the textbox. Maybe it was a cache problem at night. But now my avatar is replaced by the blog's default avatar after editing my comment :| After page refresh my avatar is back.

And yes, I got mails after editing the comment. Subject: "Comment xxxx edited" The mail includes the comment's text after editing, this is ok :)
Keep it Country,
Markus
Cowboy of Bottrop
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by onli »

The Gravatar-issue before first reload isn't that severe, is it? I have no idea how to solve it. As the comment is fetched from the db and the gravatar isn't saved there, it gets replaced.

Nice to here that the mail is working :) I forgot to check the option, but that's included in the next version I'll upload to spartacus.
sincerely
Cowboy
Regular
Posts: 29
Joined: Wed Jul 15, 2009 8:07 pm
Location: Bottrop
Contact:

Re: Commentedit: Edit comments some time after posting them

Post by Cowboy »

The avatar replacement doesn't matter. Guess, it's a s9y problem, not your's. Not to forget: S9y 1.5 is still alpha. But for that it's running good and stable ;)

Thanks for the great job.
Keep it Country,
Markus
Cowboy of Bottrop
Post Reply