Page 2 of 2
Posted: Thu Jan 04, 2007 8:54 pm
by garvinhicking
Hi Shadowin!
Wow, you're help is awesome. It does definitely make sense.
It seems IIS sets "HTTPS" to "off", but usually a webserver should keep it empty. The PHP doc says:
Code: Select all
'HTTPS'
Set to a non-empty value if the script was queried through the HTTPS protocol.
I committed your patch to our sourcecode, and it will be part of an upcoming release!
Best regards,
Garvin
More Info
Posted: Thu Jan 04, 2007 10:15 pm
by Shadowin
Thanks Gavin.
It definitely appears to be an IIS only issue.
I checked all the other code out and I didn't see performing checks like that in any other place. However, the check is performed in several different files in several different ways. I think it'd be a good idea to stick to one standard way of doing it.
If there's any room on the dev team, I will sign up and help out.
Re: More Info
Posted: Thu Jan 04, 2007 11:04 pm
by garvinhicking
Hi Shadowin!
I just published this blog post:
http://blog.s9y.org/archives/160-Serend ... s-IIS.html
So many thanks for fixing this issue! Indeed your help in the dev-team would be a great thing. If you like, you could prepare a unification patch that I could commit? Usually we first take 2-3 patches from new developers before we hand out SVN write access, if that's fine with you.
Best regards,
Garvin
Posted: Thu Jan 04, 2007 11:41 pm
by Jorick
Whoohoo!
It works again! Thanks for your help. I'm using S9Y since August 2006, and I must say: it's really good!
I hope I can help other people in the future too!
Good night,
Jorick
Posted: Fri Jan 05, 2007 12:57 am
by kharri1073
Wow thats it!! Thanks so much!
Posted: Sun Jan 07, 2007 11:00 am
by dk70
Yep, works now - thanks Shadowin. Awesome if IIS issues can be attacked faster in future.