2.5.0: No new StaticPages can be created [SOLVED]

[Huhu]

Sure, tried it with both Opera and Firefox, browser cache emptied before testing. Same result.

[onli]

I missed your edit:

The f7 file is included here, but hasn't changed since 9th of July..

The file is indeed still with the old code and will fail. I don't know why there is nothing in the log though, and the maintenance task should have nuked it. You can delete it manually, everything under templates_c/ maybe.

Edit: Oh, and be careful that you replace the right file :) I replaced the one under templates/clean_blog/, but you might have made a copy of the theme, like the templateeditor-plugin creates automatically to preserve local changes?

[Huhu]

Thanks! I replaced it under templates/clean-blog/backend_templates/default_staticpage_backend.tpl , but should it end up in templates/clean-blog/default_staticpage_backend.tpl instead, did I get that right?

I'll delete those files later and get back in touch.

[Huhu]

Mornin',
I deleted the filetree under templates_c, retried, but it doesn't make a difference. Also, there is no f6 or staticpage file created after I tried to create a new Static Page as an admin.

BUT now I got output in the error log which looks helpful, at least

Code: Select all

[proxy_fcgi:error] [pid 3...7088] [client...] 
 AH01071: Got error 'PHP message: PHP Fatal error:  
 Uncaught  --> Smarty Compiler: 
 Syntax error in template 
 "file:/.../templates/clean-blog/backend_templates/default_staticpage_backend.tpl"  
 on line 59 "<textarea data-configitem="staticpage_header_image" name="serendipity[plugin][custom][staticpage_header_image]" class="change_preview"  id="propstaticpage_header_image">
 {if $form_values.custom|is_array}
 {$form_values.custom.staticpage_header_image}{/if}
 </textarea>"
  modifier 'is_array' not allowed by security setting 
  <-- \n  thrown in /...templates/clean-blog/backend_templates/default_staticpage_backend.tpl 
  on line 59', referer: 
  https://kunz-artenschutz.de/serendipity_admin.php?serendipity[adminModule]=event_display&serendipity[adminAction]=staticpages

[onli]

Ah, ok. I'm testing under 2.6-alpha with a new Smarty release and that one changed quite a bit, maybe also how those security settings worked. Or maybe they were extended back then? I'll have a look.

[Huhu]

Thanks a lot! Looking forward.

[onli]

I'd try an individual fix first. In include/serendipity_smarty_class.inc.php there is line 20:

Code: Select all

public $php_modifiers = array('escape', 'rand', 'str_repeat', 'nl2br');

Please change it to:

Code: Select all

public $php_modifiers = array('escape', 'rand', 'str_repeat', 'nl2br', 'is_array');

So we add is_array to the list. Does the staticpage backend work now?

Sorry for not testing that for you, my dev blog has some changes right now I don't want to risk. If the fix works for you I'd say we can accept if it is fixed for all only in the 2.6.0.beta1 I want to release soon.

[Huhu]

Hi!

Excellent!! The fix works, you found it. Thank you so much, testing was a pleasure. Now the Simple Templare works as expected.
Wonderful!

[onli]

That's great to hear. Thank you as well for being this active in the fixing process. I'll now merge the PR :)

[Huhu]

Very good, thank you for providing such a quick support!
One other point for the next version might be the Static Page as Frontpage issue (as described here), which hasn't been solved by this patch, sorry to say. But most important was fixing the editor.