no idea, im not following the development of php.
i gathered that fpdf does not use the old style since its v1.53 (2004-12-31).
i have that version installed as a debian package. so why did this bite me?
guess the s9y plugin supplies its own fpdf code?
-------
next problem... freetag styling.
the background (and border) of the taglist does not match die background of the rest of the blog.
im refering to the box with related tags, that is shown, when you click on a tag and all articles with that tag are shown. i dunno if this styling is used somwhere else.
it is defined in serendipity_event_freetag.php
Code: Select all
1968 .serendipity_freetag_taglist
1969 {
1970 margin: 10px;
1971 border: 1px solid #' . $this->get_config('flash_tag_color', 'ffffff') . ';
1972 padding: 5px;
1973 background-color: #' . $this->get_config('flash_bg_color', 'ffffff') . ';
1974 text-align: justify;
1975 }
the default value is white (not only the fallback(?), seen above, but the default when it is installed). im using the mt-trendy template, which uses a dark gray background.
i disabled the flash tag cloud (or it was the default), but since the name in the config is "Flash tag cloud background color" etc. i thought it is not used for the background and forgot that this option even existed :)
and.. even more puzzeling... there is an event plugin and a sidebar plugin. both have those flash color options, but i think the sidebar plugin does not use the background color?
the color of the title font in the "Related tags" box uses selector ".serendipity_freetag_taglist", which does not define a color.
so it inherits from body. this is probably right, but than the default color in mt-trendy should be changed to match all the rest (#cccccc)? this would make a lot of "color" attributes in the template style obsolete, they could be inherited.
i dunno why this is not done, there are a lot of other occurences, where there is no distinct color set and "black" is inherited. and they all look bad.
namely "No Trackbacks", comment form explanations etc.
so..
1. please change the naming of the freetag plugin options, they are misleading atm. took its time to figure this all out :)
2. changing the mt-trendy/style.css/body/color declaration to #cccccc works fine for me and should be patched that way in the distribution imho.
3. the font color and border color of the tag clouds use the same option. they are always the same (not a problem for me/in in the "mt-trendy" template).
4. maybe the plugin should use other defaults for the colors?
the values in .serendipity_title and .serendipity_entry are responsible for the border colors of the boxes with the entries underneath the "related tags" box.
i dunno how to reference them within the freetag css or if this is even possible, but maybe the php could read it out? they would be my choice for default border colors.
for the background color of the taglist... it is nice that one can configure it, but more important (to me) would be, that the default matches the blog. so either taking the default value from the css of the body or just not set it at all and let it inherit from the parent.
hm.. adding an option to the plugin "override default colors" or something would provide both possibilities. what do you think about that?
i probably could hack that in, but id prefer not to (my youngest php code is about 7 years old... :)
5. serendipity_event_freetag/lang_en.inc.php:54:@define('PLUGIN_EVENT_FREETAG_USE_FLASH', 'Use Flash to display the tag clou
g?');
6. google search plugin
the text field is not limited in size. the text field of the internal quicksearch is.
if you use both in the side bar, they are not aligned to each others.
adding size="13" in serendipity_plugin_google_quicksearch.php:161
echo '<input type="text" name="q" maxlength="255" value="" />';
fixes this.
---
another small thing i want to provide some feedback on:
in the freetag todo list i read:
* - Remove comma-delimiting and use the 'standard' space delimiting instead
* - - convert tags with spaces to no-space tags
not using the simple (read: dumb) standard tags is a feature for me.
dunno the implications on search engines, rss readers etc. but i really don't understand why they started banning spaces in tags in first place. as long as they are case sensitive (for CamelCase formatting) this change would be ok for me, but i dont see an advantage in removing the possibility of using spaces.
it is work. it takes away freedom.
hope you preceive this posting as positive critic and not someone moaning around. i tend to sound grouchy, dunno if thats true in writing too :)
and sorry for the length.
