New static page options - please explain

Creating and modifying plugins.
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

I just came back to edit my message to use true/false for the values, not the language constants, but you beat me to it!!! :wink:

May I suggest that you update the plugin so that it demonstrates not only a radio button, but any other input type that might be available (assuming there are any more).

Also - I see that a few of the fieldsets have unique classes where you styled the font-size smaller (ie, sect_opt). Perhaps the css could have a class for just that purpose... ie <fieldset class="smalltext sect_opt"> and place the smaller font size on .smalltext instead of .sect_opt?
=Don=
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!
May I suggest that you update the plugin so that it demonstrates not only a radio button, but any other input type that might be available (assuming there are any more).
Hm, I think that having a input name and a possible value should be enough for everybody to deduce all other possible variants? I have no time to do such documentative work right now, I'm sorry.
Also - I see that a few of the fieldsets have unique classes where you styled the font-size smaller (ie, sect_opt). Perhaps the css could have a class for just that purpose... ie <fieldset class="smalltext sect_opt"> and place the smaller font size on .smalltext instead of .sect_opt?
The problem for me was that I needed to do it quick. Any patches to contribute to more cleaniness are heartly welcome :-) I agree that inline styles should be removed.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Post by Don Chambers »

Thanks Garvin - for "documentation", all I meant was adding stuff to what you already have commented out - this example of a radio button for instance.

Regarding the css, I didn't notice anything styled inline... I simply meant to change the code in the default tpl from <fieldset class="sect_opt"> to <fieldset class="sp_smalltext sect_opt">

and in the stylesheet, change this:

Code: Select all

.default_staticpage .sect_opt {
    font-size: 0.8em;
}
to this:

Code: Select all

.default_staticpage .sp_smalltext {
    font-size: 0.8em;
}
Doing so at least gives a template designer access to an already defined smaller font without having to create it themselves. Neither are show stoppers - just minor suggestions.

Thanks also for pointing out the "checked" stuff - forgot to mention that earlier.
=Don=
Post Reply