Serendipity Forums

User and developer community
https://board.s9y.org/

Since s9y_200502101337 the .jpg and .png Upload is broken

https://board.s9y.org/viewtopic.php?t=1056

Page 2 of 2

Posted: Tue Feb 15, 2005 12:23 am
by FireBird74
tomsommer wrote:And all those are broken?
No, only ID 28 and 29 are broken, the other picture where uploaded with versions bevor the s9y_200502101337 release.

Posted: Tue Feb 15, 2005 12:31 am
by FireBird74
Ok now it tested something, which works for the release of today.

I only pressed the "Rebuild Thumbs" then he generated the thumbs and i can use the pictures. He told me that he couldn't find Test 007.jpg but he has generated the Thumbs and everthing is working fine.

But now have a look at the Mysqltable:

Code: Select all

4  	pirate_logo  	jpg  	image/jpeg  	61433  	300  	217  	1106419553  	andisblogThumb  	0  	PC-Spiele/
3 	riddick_logo 	png 	image/png 	30030 	300 	102 	1106419296 	andisblogThumb 	0 	PC-Spiele/
5 	creative1 	jpg 	image/jpeg 	35023 	500 	302 	1106473240 	andisblogThumb 	0 	Creative-Teufel/
6 	creatvie2 	jpg 	image/jpeg 	28102 	500 	302 	1106473270 	andisblogThumb 	0 	Creative-Teufel/
7 	creative3 	jpg 	image/jpeg 	38463 	500 	336 	1106473293 	andisblogThumb 	0 	Creative-Teufel/
8 	creative4 	jpg 	image/jpeg 	43788 	500 	336 	1106473319 	andisblogThumb 	0 	Creative-Teufel/
9 	creatvie5 	jpg 	image/jpeg 	52660 	640 	416 	1106473343 	andisblogThumb 	0 	Creative-Teufel/
10 	creative6 	jpg 	image/jpeg 	25628 	500 	336 	1106473372 	andisblogThumb 	0 	Creative-Teufel/
11 	RepCommando 	jpg 	image/jpeg 	73741 	300 	225 	1106502465 	andisblogThumb 	0 	PC-Spiele/
12 	powered-by-gentoo 	jpg 	image/jpeg 	12582 	88 	31 	1106595490 	andisblogThumb 	0 	misc/
13 	blade_poster 	jpg 	image/jpeg 	28381 	335 	500 	1106696193 	andisblogThumb 	0 	Kino/
15 	wowlogo2 	gif 	image/gif 	58911 	262 	108 	1107353338 	andisblogThumb 	0 	PC-Spiele/
16 	saw 	jpg 	image/jpeg 	51654 	432 	640 	1107354927 	andisblogThumb 	0 	Kino/
17 	faschingrottenburg 	jpg 	image/jpeg 	136267 	640 	480 	1107787365 	andisblogThumb 	0 	misc/
18 	vallentin 	jpg 	image/jpeg 	73569 	640 	480 	1107849657 	andisblogThumb 	0 	misc/
19 	Silentium 	jpg 	image/jpeg 	27473 	297 	420 	1107954278 	andisblogThumb 	0 	Kino/
30 	Test007 	jpg 	image/jpeg 	1176982 	2608 	1952 	1108420653 	andisblogThumb 	0 	 
26 	satin 	jpg 	image/jpeg 	20070 	346 	256 	1108391250 	andisblogThumb 	0 	misc/
31 	s9y_logo 	png 	image/png 	4439 	80 	80 	1108422161 	andisblogThumb 	0
The ID's of the pictures are changed from 28 and 29 to 30 and 31.

Posted: Tue Feb 15, 2005 12:55 am
by tomsommer
The problem seems to be that it doesn't know the value for "thumbnail_name"...

Posted: Tue Feb 15, 2005 10:32 am
by garvinhicking
Just to drop in for a quick statement: I can't experience the problem as well. Image upload works fine for me with thumbnail names set to "serendipityThumb" or "s9yThumb".

I'm on imagemagick, PHP 4.3.10, Apache 1.3 module, latest serendipity.

Regards,
Garvin

Posted: Tue Feb 15, 2005 11:01 am
by FireBird74
garvinhicking wrote: I'm on imagemagick, PHP 4.3.10, Apache 1.3 module, latest serendipity.
Me, too. It isn't the server or the php version, this Server holds over 300 VHosts all using differend kinds of php Scripts / Blogs / CMS they are all working fine.
Maybe it's a PHP_FLAG or a PHP_VALUE like magic quotes, sort order or anything else, but i didn't changed anything, only upgraded the Version.

I will test a clean installation - downloading the latest .tar.gz File an try it again, maybe it's a problem with an "old" file, because i have no cvs client on this server i only can download the .tar.gz files from the s9y homepage.

I will post you the result asap.

Posted: Tue Feb 15, 2005 11:40 am
by FireBird74
Ok i have tested it now with a clean installation an it's NOT working, same errors with the images as before.

Posted: Tue Feb 15, 2005 12:03 pm
by tomsommer
It has to be when getimagesize() can't return the mimetype.


What PHP versions are you guys using?

Posted: Tue Feb 15, 2005 12:52 pm
by garvinhicking
Could it be that mime-detection only works if "--enable-exif" is set? It's set in my installation:

Code: Select all

'./configure' '--enable-calendar' '--enable-ftp' '--with-gettext' '--with-openssl' '--enable-memory-limit' '--enable-mbstring' '--enable-sockets' '--with-pgsql' '--with-apxs=/usr/local/apache/bin/apxs' '--enable-cli' '--enable-bcmath' '--with-bz2' '--with-mcrypt' '--with-mysql' '--with-gd' '--with-zlib' '--with-t1lib=/usr/include' '--with-jpeg-dir=/usr/lib' '--with-png-dir=/usr/include/' '--enable-exif' '--with-freetype-dir=/usr/include/freetype2/freetype/' '--enable-gd-native-ttf' '--with-gettext' '--with-imap' '--with-kerberos'

Posted: Tue Feb 15, 2005 12:54 pm
by tomsommer
http://www.tomsommer.dk/phpinfo.php

Posted: Tue Feb 15, 2005 1:08 pm
by garvinhicking
Firebird,

I just committed this patch to CVS. Could you please see, if this helps on your installation:

Code: Select all

Index: include/admin/images.inc.php
===================================================================
RCS file: /cvsroot/php-blog/serendipity/include/admin/images.inc.php,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- include/admin/images.inc.php        9 Feb 2005 19:46:10 -0000       1.17
+++ include/admin/images.inc.php        15 Feb 2005 12:07:01 -0000      1.18
@@ -1,4 +1,4 @@
-<?php # $Id: images.inc.php,v 1.17 2005/02/09 19:46:10 tomsommer Exp $
+<?php # $Id: images.inc.php,v 1.18 2005/02/15 12:07:01 garvinhicking Exp $
 # Copyright (c) 2003-2005, Jannis Hermanns (on behalf the Serendipity Developer Team)
 # All rights reserved.  See LICENSE file for licensing details

@@ -143,7 +143,7 @@
                     echo THUMB_CREATED_DONE . '<br />';
                 }
                 // Insert into database
-                $image_id = serendipity_insertImageInDatabase($_FILES['userfile']['name'], $directory, $authorid);
+                $image_id = serendipity_insertImageInDatabase($tfile, $serendipity['POST']['target_directory'], $authorid);
             }
         }
     } else {
@@ -176,7 +176,7 @@
                     echo THUMB_CREATED_DONE . '<br />';
                 }
                 // Insert into database
-                $image_id = serendipity_insertImageInDatabase($_FILES['userfile']['name'], $directory, $authorid);
+                $image_id = serendipity_insertImageInDatabase($tfile, $serendipity['POST']['target_directory'], $authorid);
             } else {
                 echo ERROR_UNKNOWN_NOUPLOAD . '<br />';
             }
Regards,
Garvin

Posted: Tue Feb 15, 2005 1:11 pm
by FireBird74
As this Server is a Hosting System i have many more configure options but i have the exif option enabled.

Code: Select all

Apache 1.3.xx with mod_php and mod_rewrite 

PHP Version 4.3.10

System 	Linux pool2 2.6.9-gentoo-r1 #2 SMP Thu Oct 28 20:11:16 CEST 2004 i686

Build Date 	Jan 4 2005 09:35:00

Configure Command 	'./configure' '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--with-apxs=/usr/sbin/apxs' '--with-ndbm=/usr' '--with-db4=/usr' '--with-mcrypt=/usr' '--with-mhash=/usr' '--without-interbase' '--without-ming' '--without-swf' '--without-sybase' '--with-gdbm=/usr' '--without-fdftk' '--without-java' '--without-mcal' '--with-oci8=/oracle/product/9.2.0' '--without-unixODBC' '--without-pgsql' '--with-snmp=/usr' '--enable-ucd-snmp-hack' '--without-gmp' '--without-mssql' '--with-pdflib=/usr' '--with-gd' '--enable-gd-native-ttf' '--with-png=/usr' '--with-png-dir=/usr' '--with-jpeg=/usr' '--with-jpeg-dir=/usr' '--enable-exif' '--with-tiff=/usr' '--with-tiff-dir=/usr' '--with-mysql=/usr' '--with-mysql-sock=/var/run/mysqld/mysqld.sock' '--with-freetype-dir=/usr' '--with-ttf=/usr' '--with-t1lib=/usr' '--with-gettext' '--without-qtdom' '--with-pspell=/usr' '--with-openssl=/usr' '--with-imap=/usr' '--without-ldap' '--with-dom=/usr' '--with-dom-xslt=/usr' '--with-dom-exslt=/usr' '--without-kerberos' '--with-pam' '--disable-memory-limit' '--enable-ipv6' '--without-yaz' '--disable-debug' '--with-curlwrappers' '--with-curl=/usr' '--enable-dbx' '--with-imap-ssl' '--with-zlib=/usr' '--with-zlib-dir=/usr' '--with-sablot=/usr' '--enable-xslt' '--with-xslt-sablot' '--with-xmlrpc' '--enable-wddx' '--with-xml' '--enable-mbstring=all' '--enable-mbregex' '--with-bz2=/usr' '--with-crack=/usr' '--with-cdb' '--enable-pcntl' '--enable-bcmath' '--enable-calendar' '--enable-dbase' '--enable-filepro' '--enable-ftp' '--with-mime-magic=/usr/share/misc/file/magic.mime' '--enable-sockets' '--enable-sysvsem' '--enable-sysvshm' '--enable-sysvmsg' '--with-iconv' '--enable-shmop' '--enable-dio' '--enable-yp' '--without-ncurses' '--without-readline' '--enable-inline-optimization' '--enable-track-vars' '--enable-trans-sid' '--enable-versioning' '--with-config-file-path=/etc/php/apache1-php4' '--without-pear'

Posted: Tue Feb 15, 2005 1:14 pm
by garvinhicking
FireBird, I spot this line:

Code: Select all

'--with-mime-magic=/usr/share/misc/file/magic.mime'
Maybe this is the cause of your trouble. Does the file exist and contain real and correct mime types?

Regards,
Garvin

Posted: Tue Feb 15, 2005 2:01 pm
by FireBird74
garvinhicking wrote:FireBird, I spot this line:

Code: Select all

'--with-mime-magic=/usr/share/misc/file/magic.mime'
Maybe this is the cause of your trouble. Does the file exist and contain real and correct mime types?

Regards,
Garvin
I know about this line, the file ist there and there are entires for png and jpeg, but this file hasn't changed and we have 5 hugh CMS Installations on the system which also using mime.type in its Mediamanagers and there we have no problems at all.

Posted: Tue Feb 15, 2005 2:15 pm
by FireBird74
garvinhicking wrote:Firebird,

I just committed this patch to CVS. Could you please see, if this helps on your installation:

Regards,
Garvin
;-) Yep this helps - now i can upload jpg and png files again, without any problems. This seems to work fine.

Regards
Firebird :)

Posted: Tue Feb 15, 2005 9:08 pm
by Sheeley
Nevermind, just read the code. Thanks for the update, looks like it should help. :)
All times are UTC+02:00
Page 2 of 2

Powered by phpBB® Forum Software © phpBB Limited