proposal for comments

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

proposal for comments

Post by konus »

Hello,
I would like to make some suggestions/wishes to enhance comment handling in s9y:
  1. in the email, s9y sends to me about a comment, I would like to see the referrer (helps to decide if it is spam or not)
  2. After calling the links with the comment_tokens from the email, (approving or deleting the comment) S9y opens up a blank page and gives some feedback "comment # 1080 was deleted" or "approved" - I would like to have a link to the article here.
  3. After login, under all comments appears the "delete"-Link (I use bulletproof). It would be useful to show a "modify"-Link too .
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: proposal for comments

Post by konus »

Hi,
I made some small modifications to functions_comments.inc.php from /include/ to solve whish No.1 Here is the file (zipped, see last paragraph)

Then I tried to solve my wish No.2, but did not find a way to make the link clickable in
die($return_msg)
The output is not html, but text. Is there a way to solve this?

Here is my work so far (file, zipped, line 109 - 112).
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: proposal for comments

Post by garvinhicking »

Hi!

Great, committed your 1st patch!

Wish no2 is not solvable this way. The output is a plaintext output. If it were HTML, we would need to add all kind of HTML head/body structure to the output.

But when you click the link in your mailclient, you also have the original link there, so you could simply first click on the moderation link and immediately also click on the entry title which would open both URLs in your browser?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
konus
Regular
Posts: 334
Joined: Mon Jun 16, 2008 1:57 pm
Location: Dresden, Germany
Contact:

Re: proposal for comments

Post by konus »

You are right, it is just a matter of workflow. I will call the url in my mailclient.
Post Reply