new event calendar plugin

[Timbalu]

you have post

Ian

[Don Chambers]

Still exists in plugin folder (non utf-8):

Code: Select all

    @define('PLUGIN_EVENTCAL_ERROR_COLOR_START', '<font color=#ff0000> ');
    @define('PLUGIN_EVENTCAL_ERROR_COLOR_END', ' </font>');

Remember, I did not verify all definitions - just the few I mentioned earlier. Did you verify the rest? No need for those files to be any larger than they have to be. I also cannot help but wonder if a few of your plugin constants could be replaced by global constants... for instance, these are in the plugin:

Code: Select all

    @define('PLUGIN_EVENTCAL_PAGINATOR_NEXT', 'Next');
    @define('PLUGIN_EVENTCAL_PAGINATOR_LAST', 'Last');

And these are global:
@define('PREVIOUS', 'Previous');
@define('NEXT', 'Next');

[Timbalu]

please load next edition!

Ian

[Don Chambers]

Earlier I recommended that you look carefully at both the stylesheet and the language files for things no longer in use by the template. I found more in the language files:

Code: Select all

    @define('PLUGIN_EVENTCAL_NEXTPAGE', 'next page');
    @define('PLUGIN_EVENTCAL_PREVPAGE', 'prev page');
    @define('PLUGIN_EVENTCAL_TEXT_DELETE', 'delete');
    @define('PLUGIN_EVENTCAL_TEXT_SAY', 'said');
    @define('PLUGIN_EVENTCAL_TEXT_EMAIL', 'E-mail');
    @define('PLUGIN_EVENTCAL_TEXT_NAME', 'Name');

    @define('PLUGIN_EVENTCAL_ERROR_COMMENTEMPTY', 'Please insert a text.');
    @define('PLUGIN_EVENTCAL_ERROR_NAMEEMPTY', 'Please insert your name.');
    @define('PLUGIN_EVENTCAL_ERROR_TIMELOCK', 'Please wait at least %s seconds before posting again!');
    @define('PLUGIN_EVENTCAL_ERROR_TELEPHONEMPTY', 'Please insert your telephone number.');
    @define('PLUGIN_EVENTCAL_ERROR_TITLEEMPTY', 'Please insert a valid title.');
    @define('PLUGIN_EVENTCAL_ERROR_EMAILEMPTY', 'Please insert a valid email.');
    @define('PLUGIN_EVENTCAL_ERROR_DATATOSHORT', 'Your entry should have at least 3, in the comment field at least 10 characters.');
    @define('PLUGIN_EVENTCAL_ERROR_NOVALIDEMAIL', 'Your e-mail address appears invalid: ');
    @define('PLUGIN_EVENTCAL_ERROR_NOINPUT', 'Please enter your name, e-mail address and a comment');

    @define('PLUGIN_EVENTCAL_ERROR_UNKNOWN', 'An unknown error occured. Please try again or inform the webmaster of this site. Thank you!');
    @define('PLUGIN_EVENTCAL_ERROR_OCCURRED', 'There are some errors:');
    @define('PLUGIN_EVENTCAL_ERROR_SELECTED_ISFALSE', 'Permalink or subpage path are not valid! Please change.');

I suggested you look for others earlier. I am not looking any further after finding this many - I think you can look over the language files faster than I can. Once again, I STRONGLY suggest you determine if you have language constants in these files that are no longer being used by the plugin. I also suggest you eliminate the 4 spaces that preceed each one as it serves no purpose and makes the file larger than it has to be (geeze - I sound like Garvin). I also suggest converting the file to unix format if your text editor allows that.

And, for the second time, I will suggest that you look closely at the stylesheet for anything that is also no longer in use. I suspect there are many lines in that file that are no longer necessary. That stylesheet is massive!! I count 24 instances of "arial". Why would you constantly define the font face? It also has the 4 leading spaces for every line, and lots of code that has been commented out but not removed. And I do not think this should be in the stylesheet:

Code: Select all

    .serendipity_entry .serendipity_entry_body {
        clear: both;
    }
    /* obfuscating spamblock markup and emoticate text */
    .serendipity_comment_s9ymarkup {
        display: none;
    }
    .serendipity_comment_emoticate {
        display: none;
    }

You now have both your original code, and my suggested modification:

Code: Select all

{if $is_eventcal_error}
<div class="serendipity_center eventcal_tpl_error">
    <div class="eventcal_tpl_error_inner">{$plugin_eventcal_error}</div>
</div>
<div class="serendipity_center serendipity_msg_important">{$plugin_eventcal_error}</div>
{/if}

And all the css for your original classes still exists in the stylesheet....

One final favor - Perhaps you could post a reply on what you have changed, and what you have not changed (and why). Some of my suggestions have not been implemented (which is fine) but I do not know if it was an oversight, or a deliberate decision.

[Timbalu]

Hi Don,

lang files, spaces, unix style are ok - thanks for your hints!

And, for the second time, I will suggest that you look closely at the stylesheet for anything that is also no longer in use. I suspect there are many lines in that file that are no longer necessary. That stylesheet is massive!! I count 24 instances of "arial". Why would you constantly define the font face? It also has the 4 leading spaces for every line, and lots of code that has been commented out but not removed. And I do not think this should be in the stylesheet:

Code: Select all

    .serendipity_entry .serendipity_entry_body {
        clear: both;
    }
    /* obfuscating spamblock markup and emoticate text */
    .serendipity_comment_s9ymarkup {
        display: none;
    }
    .serendipity_comment_emoticate {
        display: none;
    }

You mean multi occurances of

Code: Select all

font: xx-small arial, helvetica, sans-serif;

which is definitely working code and not much more than

Code: Select all

font-size: xx-small;

which is not working.

The three others you mentioned above we do need them, while first we make sure no default rules are disturbing and while second there is no need for spamblock markup and emoticate text when using captchas. HTML5 says the style element in html will fall away, so these rules have to be in the stylesheet.

And all the css for your original classes still exists in the stylesheet....

Yes! As I said, it is everybodys own decision to change this to personal preferences. My experience with errors and messages told me to spend some more effort to users being to quick and don't have an eye on them.

One final favor - Perhaps you could post a reply on what you have changed, and what you have not changed (and why). Some of my suggestions have not been implemented (which is fine) but I do not know if it was an oversight, or a deliberate decision.

Well, I can't report all the changes and desisions I have made, I simply cannot remember all of them, but be asured I have read all your suggestions onestly and would say, that - with a few exceptions as an oversight - the remaining rest is a deliberate descision.

Regards,
Ian

[Timbalu]

A new version is online, Don.
Hopefully the last, even if I couldn't satisfy you in all matters.

Ian

[Don Chambers]

Sorry Ian - got sidetracked with other obligations. Will test your latest version tomorrow.

[Timbalu]

Hi Don

Yes, and don't forget to load the newest version. I made some enhancements to the eventcal code.

Ian