No "paging" in media db

Found a bug? Tell us!!
Post Reply
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

No "paging" in media db

Post by yellowled »

Hohum. I just noticed that if I click "Next" in the media db overview, the media db, well, doesn't go to the next page. The URL changes from i.e.

Code: Select all

/serendipity_admin.php?serendipity[adminModule]=media
to

Code: Select all

/serendipity_admin.php?serendipity[adminModule]=media&serendipity[sortorder][perpage]=&serendipity[sortorder][order]=&serendipity[sortorder][ordermode]=&serendipity[page]=2
but I still get the same images displayed as on page 1.

This is the latest revision (2592) from svn running on a local Ubuntu lamp (PHP 5.2.6).

Bug or quirk in my local installation?

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: No "paging" in media db

Post by garvinhicking »

Hi!

A very good catch. This was introduced by a patch that changed the image workflow to redirect to the overview after upload. Another sideeffect of this has also been fixed just recently, and I now also committet the fix for the behaviour you reported.

MANY thanks for that one, I'm glad we hadn't released 1.5 yet :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: No "paging" in media db

Post by yellowled »

garvinhicking wrote:MANY thanks for that one, I'm glad we hadn't released 1.5 yet :)
Me too :) Funny no one noticed, though. Quite a lot of people seem to use 1.5betaX already. Guess this isn't something one stumbles upon easily.

YL
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: No "paging" in media db

Post by onli »

Puh, thanks yellowled. Quite a lot of bugs I introduced with that one, sorry (haven't noticed that because there are not enough images in my testenvironment - yet. And simply wasn't aware of that behavior).
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: No "paging" in media db

Post by garvinhicking »

Hi!

No harm done, we caught it before the spotlight :)
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: No "paging" in media db

Post by Don Chambers »

I do not know if this is related or not.... Running latest 1.5 beta via SVN and php 5.3.0:

Create/edit an entry.
Click on button to insert something from the media library.
Image is not yet in my media library, so select "add media".

Returned to the edit entry page with this the only thing inserted into the entry:

Code: Select all

<a href="" title="" target="_blank"></a>
Something else, which may have never worked for all I know:

Create/edit an entry.
Click on button to insert something from the media library.
Before selecting an image, delete an existing image.
Button to add media is no longer present once an existing image has been deleted.
=Don=
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: No "paging" in media db

Post by onli »

The empty insert is something that's not happening on my local installation with the changes I made to this, so this is not necessarily related. But I'll try the latest version and see if that is connected anyway, it could be it's part of the latest changes to fix "my" bug.
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: No "paging" in media db

Post by onli »

Tested with the last snapshot, I can't reproduce the error you described, Don. Can you test that again, if it's still present and if yes, maybe describe it again?
Don Chambers
Regular
Posts: 3657
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: No "paging" in media db

Post by Don Chambers »

Create an entry.
Insert an image via the "Media" button (non wysiwyg editor)
Instead of selecting an existing image, upload one via "Add Media" button.
Browse your computer, select image, then "Go" to upload the image.

Image is uploaded, but you are never given an opportunity to select the large or thumbnail version, and the image is NOT inserted. What is inserted into the entry is just:

Code: Select all

<a href="" title="" target="_blank"></a>
=Don=
onli
Regular
Posts: 3044
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: No "paging" in media db

Post by onli »

Thanks. This error is definitely not present with the last snapshot on my installation. I get the option to select the whole image or a thumbnail and the insert works correct. Can anyone else reproduce this?
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: No "paging" in media db

Post by yellowled »

onli wrote:Can anyone else reproduce this?
Just tried it as Don suggested -- works fine with a recent snapshot in Firefox 3.5.4. The reason I'm pointing this out is that I know Don still uses FF2 or IE -- maybe that's the reason it doesn't work for him ..?

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: No "paging" in media db

Post by garvinhicking »

Hi!

For me as well this works properly with the recent snapshot!

(FF3, but should be unrelated)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply